Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Parquet] Implement DebugPrintState() for all types of TypedRecordReader #45273

Open
mapleFU opened this issue Jan 15, 2025 · 3 comments
Open

[C++][Parquet] Implement DebugPrintState() for all types of TypedRecordReader #45273

mapleFU opened this issue Jan 15, 2025 · 3 comments
Assignees
@kevinmingtarja
Labels
Component: C++ Component: Parquet Type: enhancement

Comments

@mapleFU
Copy link
Member

mapleFU commented Jan 15, 2025

Describe the enhancement requested

// TODO(wesm): Implement these to some satisfaction
template <>
void TypedRecordReader<Int96Type>::DebugPrintState() {}

template <>
void TypedRecordReader<ByteArrayType>::DebugPrintState() {}

template <>
void TypedRecordReader<FLBAType>::DebugPrintState() {}

Currently they're not implemented, which is hard to debug.

Component(s)

C++, Parquet
@kevinmingtarja
Copy link
Contributor

Hi, I'd love to make a PR for this if nobody is working on it.

@mapleFU
Copy link
Member Author

mapleFU commented Jan 17, 2025

Feel free to do this!

@kevinmingtarja
Copy link
Contributor

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinmingtarja kevinmingtarja

Labels
Component: C++ Component: Parquet Type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mapleFU @kevinmingtarja