-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ParquetField
public
#6991
Make ParquetField
public
#6991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me too.
ParquetField currently has public members, we might want to change this. As it stands even adding a field would be a breaking API change once made public Taking a step back, why do you want this public, what public APIs make use of it? |
The current
That's a good point, but this specific type has not changed for 3 years and probably won't change for a while. |
Perhaps we could make this public under the same experimental feature gate? I'm being cautious as we've been stung in the past by exposing too much of this crates' internals |
Sounds great! Will do soon |
Marking as draft -- please mark it as ready to review when it is |
Which issue does this PR close?
Closes #.
Rationale for this change
ParquetField
(and its friends) are foundation types in the crate, without this being public, many of the functions can't be called, e.g.,build_array_reader
. If this is public, downstream users can easily hooking their own parquet reading logic while still reusing much of the existing code.What changes are included in this PR?
Are there any user-facing changes?