Add example reading data from an mmaped IPC file
#6986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/mmap_example
branch
from
b6df782 to
1c0b81e
Compare
alamb
commented
Jan 15, 2025
| @@ -87,6 +87,9 @@ criterion = { version = "0.5", default-features = false } | |||
| half = { version = "2.1", default-features = false } | |||
| rand = { version = "0.8", default-features = false, features = ["std", "std_rng"] } | |||
| serde = { version = "1.0", default-features = false, features = ["derive"] } | |||
| # used in examples | |||
| memmap2 = "0.9.3" | |||
| bytes = "1.9" | |||
There was a problem hiding this comment.
we could avoid this bytes dependency if we added Buffer::from_owned
alamb
commented
Jan 15, 2025
| use std::path::PathBuf; | ||
| use std::sync::Arc; | ||
|
|
||
| /// This example shows how to read data from an Arrow IPC file without copying |
There was a problem hiding this comment.
I re-read the code in StreamDecoder again and I am pretty sure it will also be zero copy array creation if fed via StreamDecoder::decode --
arrow-rs/arrow-ipc/src/reader/stream.rs
Line 131 in fc6936a
Perhaps I can extend this example to show that as well 🤔
|
Thank you for the review @tustvold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Reading arrow IPC files without copying is a key format feature, but it is hard to understand how to make this happen today
What changes are included in this PR?
mmapwithFileDecoderAre there any user-facing changes?
Example
Potential follow ons (TODO):
Buffer::from_owneras suggested by @tustvold in MMap support for IPC files #6709 (comment)IPCBufferDecoderor something similar into the actual crate API