Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WASM CI for Rust 1.84 release #6963

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 10, 2025

Which issue does this PR close?

Closes #.

Rationale for this change

Rust 1.84 was released yesterday: https://blog.rust-lang.org/2025/01/09/Rust-1.84.0.html 🎉

Unfortunately, this broke our WASM builds:

https://github.com/apache/arrow-rs/actions/runs/12698871454/job/35398265255

Installing stable
info: syncing channel updates for 'stable-x86_64-unknown-linux-gnu'
info: latest update on 2025-01-09, rust version 1.84.0 (9fc6b4312 2025-01-07)
error: component 'rust-std' for target 'wasm32-wasi' is unavailable for download for channel 'stable'
If you don't need the component, you could try a minimal installation with:

    rustup toolchain add stable --profile minimal

If you require these components, please install and use the latest successful build version,
which you can find at <https://rust-lang.github.io/rustup-components-history>.

After determining the correct date, install it with a command such as:

    rustup toolchain install nightly-2018-12-27

Then you can use the toolchain with commands such as:

    cargo +nightly-2018-12-27 build

What changes are included in this PR?

  1. Update the name of the wasm target to reflect the new name. See this blog for details: https://blog.rust-lang.org/2024/04/09/updates-to-rusts-wasi-targets.html

Are there any user-facing changes?

No, this is only a CI change

@alamb alamb changed the title Fix CI for Rust 1.84 release Fix WASM CI for Rust 1.84 release Jan 10, 2025
@alamb alamb marked this pull request as ready for review January 10, 2025 19:00
@alamb
Copy link
Contributor Author

alamb commented Jan 10, 2025

Thank you for the review @tustvold

@alamb
Copy link
Contributor Author

alamb commented Jan 10, 2025

Merging this one in to get CI passig

@alamb alamb merged commit 30abb47 into apache:main Jan 10, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants