add binary support in arrow-string #6926
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(ignore branch name)
Which issue does this PR close?
Closes #6923
What changes are included in this PR?
PredicateImpltrait to work with the predicate regardless of string or binaryPredicateImplfor the oldPredicateand the newBinaryPredicateusing macro (I don't really like this as it seem less maintainable, but not sure what's better, duplicating or macro, or another approach)Are there any user-facing changes?
Yes, allow users to pass binary arrays to like/starts with/contains and more