Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss: Release object store 0.12.0 (breaking) or 0.11.2 (non breaking API) around Dec 15, 2024 #6596

Closed
2 tasks
alamb opened this issue Oct 20, 2024 · 7 comments · Fixed by #6904
Closed
2 tasks
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@alamb
Copy link
Contributor

alamb commented Oct 20, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Follow on to #6121

object_store 0.11.1 was released Oct 20, 2024

Per release schedule here https://github.com/apache/arrow-rs/tree/master?tab=readme-ov-file#object_store-crate we aim for
2 months release

Describe the solution you'd like

  • Update version + make release noted
  • Prepare release candidate + begin vote thread
  • [] Release to crates.io

Describe alternatives you've considered

  1. Another incremental release
  2. A major release including breaking API changes (e.g. to include object_store: Migrate from snafu to thiserror #6266)

Additional context
I don't have any preference, though I personally think #6266 is a nice to have

@alamb alamb added the enhancement Any new improvement worthy of a entry in the changelog label Oct 20, 2024
@alamb alamb changed the title Discuss: Release object store 0.11.0 (breaking) or 0.11.2 (non breaking API) around Dec 15, 2024 Discuss: Release object store 0.12.0 (breaking) or 0.11.2 (non breaking API) around Dec 15, 2024 Oct 20, 2024
@tustvold
Copy link
Contributor

I agree that at the moment we probably don't have enough to justify a breaking release.

Some other things that might be breaking, but not sure if/when we will see anything in that space

@alamb
Copy link
Contributor Author

alamb commented Dec 18, 2024

I propose that we plan to make the next object_store release 0.11.2 (non breaking) and try to make it next week. Please let me know if you have ojections

@tustvold
Copy link
Contributor

tustvold commented Dec 18, 2024

I'd like to propose we proceed as planned with a non-breaking release next week, and then do a breaking release late February in advance of the scheduled March breaking arrow release. There are some non-trivial new features / bug fixes that I am aware people are waiting on use releasing, and a breaking release would significantly delay getting these into the hands of users.

However, having the next release be breaking would allow us to start incorporating breaking changes into main in a week's time, once this release has been cut.

If there are major non-breaking features that land during that time, we can consider cutting another 0.11 patch release, presuming the contributor is willing to backport their changes.

@alamb
Copy link
Contributor Author

alamb commented Dec 18, 2024

I think @tustvold 's plan sounds good. Unless there objections I'll update the tickets to reflect that

@benesch
Copy link
Contributor

benesch commented Dec 18, 2024

Sounds great to me as well! Eager to be able to incorporate this into SlateDB.

@alamb
Copy link
Contributor Author

alamb commented Dec 18, 2024

@criccomini
Copy link
Contributor

🔥 very excited to incorporate the new CAS feature into SlateDB. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants