Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unsafe/unchecked slicing #6900

Closed
emilk opened this issue Dec 18, 2024 · 1 comment
Closed

Add unsafe/unchecked slicing #6900

emilk opened this issue Dec 18, 2024 · 1 comment
Labels
development-process Related to development process of arrow-rs enhancement Any new improvement worthy of a entry in the changelog

Comments

@emilk
Copy link
Contributor

emilk commented Dec 18, 2024

When the user has already done their own bound checking, they don't want to pay for it again. Therefore I propose the slice methods has an unsafe _unchecked version.

We used these methods in arrow2 extensively, and found the performance different to be quite significant for our use case.
@emilk emilk added the enhancement Any new improvement worthy of a entry in the changelog label Dec 18, 2024
This was referenced Dec 18, 2024
Closed
Open
@emilk
Copy link
Contributor Author

emilk commented Dec 19, 2024

After some internal review it's become clear that this ugly code-generated arrow-derserialization we do is never on the fast path (anymore), so we don't need this after all. Sorry for the noise!

@emilk emilk closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2024
@tustvold tustvold added the development-process Related to development process of arrow-rs label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
development-process Related to development process of arrow-rs enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add unsafe/unchecked slice functions rerun-io/arrow-rs
2 participants
@emilk @tustvold