Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise Decimal Casting #6877

Open
tustvold opened this issue Dec 12, 2024 · 0 comments
Open

Optimise Decimal Casting #6877

tustvold opened this issue Dec 12, 2024 · 0 comments
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently the decimal conversion kernels perform unnecessary checks, this predates #6836 although is made worse by this PR.

In particular when performing a decimal conversion between the same decimal primitive (i.e. Decimal128 vs Decimal256) it should be able to elide both the checks in O::Native::from_decimal and O::validate_decimal_precision. This in turn would allow using the infallible unary kernel, likely yielding significant performance improvements.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

No branches or pull requests

1 participant