Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object_store errors when reqwest gzip feature is enabled #6842

Closed
phillipleblanc opened this issue Dec 6, 2024 · 1 comment · Fixed by #6843
Closed

object_store errors when reqwest gzip feature is enabled #6842

phillipleblanc opened this issue Dec 6, 2024 · 1 comment · Fixed by #6843
Labels
bug object-store Object Store Interface

Comments

@phillipleblanc
Copy link
Contributor

phillipleblanc commented Dec 6, 2024

Describe the bug

Reqwest has a non-default feature gzip that will add the Content-Encoding: gzip headers and automatically decompresses the gzipped responses, with the side-effect of removing the Content-Length header. The object_store crate expects the Content-Length header to be present and will error otherwise.

This has the side-effect of code that was previously working could suddenly stop working if any dependency in the project enables the gzip feature for reqwest AND the HTTP server supports the Accept-Encoding: gzip header.

To Reproduce

I've created a minimal repro illustrating the bug here: https://github.com/phillipleblanc/object_store_gzip_repro

Expected behavior

Even if the gzip feature is enabled for reqwest, the object_store client should continue to work when making requests against HTTP servers that support gzip compression.

Additional context

N/A

@alamb
Copy link
Contributor

alamb commented Dec 17, 2024

label_issue.py automatically added labels {'object-store'} from #6843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug object-store Object Store Interface
Projects
None yet
2 participants