From 21e015b13dae40442bec0a918188131dc8f2906f Mon Sep 17 00:00:00 2001 From: Xiangpeng Hao Date: Wed, 8 Jan 2025 10:04:25 -0600 Subject: [PATCH] remove unrelated changes --- parquet/src/arrow/array_reader/byte_view_array.rs | 5 ----- parquet/src/arrow/arrow_reader/filter.rs | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/parquet/src/arrow/array_reader/byte_view_array.rs b/parquet/src/arrow/array_reader/byte_view_array.rs index f3b7bf46d5d1..64d839fa5874 100644 --- a/parquet/src/arrow/array_reader/byte_view_array.rs +++ b/parquet/src/arrow/array_reader/byte_view_array.rs @@ -169,9 +169,7 @@ impl ColumnValueDecoder for ByteViewArrayColumnValueDecoder { self.validate_utf8, ); decoder.read(&mut buffer, usize::MAX)?; - self.dict = Some(buffer); - Ok(()) } @@ -309,9 +307,6 @@ impl ByteViewArrayDecoderPlain { num_values: Option, validate_utf8: bool, ) -> Self { - // Here we convert `bytes::Bytes` into `arrow_buffer::Bytes`, which is zero copy - // Then we convert `arrow_buffer::Bytes` into `arrow_buffer:Buffer`, which is also zero copy - let buf = arrow_buffer::Buffer::from_bytes(buf.clone().into()); Self { buf: Buffer::from(buf), offset: 0, diff --git a/parquet/src/arrow/arrow_reader/filter.rs b/parquet/src/arrow/arrow_reader/filter.rs index 931e13e252f5..2e22f7e01cf0 100644 --- a/parquet/src/arrow/arrow_reader/filter.rs +++ b/parquet/src/arrow/arrow_reader/filter.rs @@ -110,7 +110,7 @@ where /// [`RowSelection`]: crate::arrow::arrow_reader::RowSelection pub struct RowFilter { /// A list of [`ArrowPredicate`] - pub predicates: Vec>, + pub(crate) predicates: Vec>, } impl RowFilter {