feat: make prometheus shared dict configurable #793
Conversation
| @@ -448,6 +448,9 @@ apisix: | |||
| # - name: bar | |||
| # size: 1m | |||
|
|
|||
| # Set the size of prometheus-metrics shared dict | |||
| prometheusSharedDictSize: 15m | |||
There was a problem hiding this comment.
🤔 Is it a good idea to use a separate orphaned key?
Wouldn't it be better to implement it as a map and allow the original shared dict name used by APISIX to be passed in directly for overriding. e.g.
luaSharedDicts:
- name: prometheus-metrics
size: 100mIf you think this is unclear, perhaps it could also be called builtinLuaSharedDicts. Or, make it configurable by customLuaSharedDicts, although not intuitive.
BTW, if you update the values template, please update the documentation along with it.
There was a problem hiding this comment.
it is very specific (in the otherwise unused meta key) in the upstream config, and the same mechanism doesn't seem to be used anywhere else, so I opted for a single specific key, but feel free to request a specific change if you have something in mind
ref: https://github.com/apache/apisix/blob/ee6a04cad1bab24ae0305a3cd66bb4e88812edb7/conf/config.yaml.example#L166
fixes #769