Added Zombie and Cleaning Scan states #4983
Conversation
| if (session.getScanTask() == null) { | ||
| state = ScanState.IDLE; | ||
| } else { | ||
| switch (scanTask.getScanRunState()) { | ||
| switch (session.getScanTask().getScanRunState()) { |
There was a problem hiding this comment.
could store the scan task in a var
server/tserver/src/main/java/org/apache/accumulo/tserver/session/SessionManager.java
Outdated
Show resolved
Hide resolved
server/tserver/src/main/java/org/apache/accumulo/tserver/session/SessionManager.java
Outdated
Show resolved
Hide resolved
server/tserver/src/main/java/org/apache/accumulo/tserver/session/SessionManager.java
Outdated
Show resolved
Hide resolved
server/tserver/src/main/java/org/apache/accumulo/tserver/session/SessionManager.java
Outdated
Show resolved
Hide resolved
server/tserver/src/main/java/org/apache/accumulo/tserver/session/SessionManager.java
Outdated
Show resolved
Hide resolved
server/tserver/src/main/java/org/apache/accumulo/tserver/session/SessionManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
A couple comments. The current logic doesn't look entirely correct to me but I'm not sure what should be changed.
@keith-turner - do you have any ideas/suggestions on my comments?
| if (scanTask == null) { | ||
| state = ScanState.IDLE; | ||
| if (session.getState() == State.REMOVED) { | ||
| state = ScanState.CLEANING; | ||
| } else { | ||
| switch (scanTask.getScanRunState()) { | ||
| switch (session.getScanTask().getScanRunState()) { |
There was a problem hiding this comment.
This removes the null check for the scanTask and I think it would still be needed, however, I'm not sure where it would go especially considering my next comment
| if (session.getState() == State.REMOVED) { | ||
| state = ScanState.ZOMBIE; | ||
| } | ||
| break; |
There was a problem hiding this comment.
The current logic is:
if (session.getState() == State.REMOVED) {
state = ScanState.CLEANING;
} else {
...
if (session.getState() == State.REMOVED) {
state = ScanState.ZOMBIE;
}
...
}
state = ScanState.ZOMBIE will never execute in this logic. It seems like either (or both) the logic for identifying ZOMBIE or CLEANING need to be changed (but I'm not sure which or what it should be changed to)
Added zombie and cleaning states to Admin and Thrift. Made methods to handle when the state is set to cleaning or zombie.
closes issue #4843