Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: modify actions #90

Open
rowrowrowrow opened this issue Mar 12, 2021 · 4 comments
Open

Feature Request: modify actions #90

rowrowrowrow opened this issue Mar 12, 2021 · 4 comments

Comments

@rowrowrowrow
Copy link
Contributor

rowrowrowrow commented Mar 12, 2021

Hi, thanks for the great package!

Would you consider adding a function to the configuration for modifying the actions before they are sent?

@aohua
Copy link
Owner

aohua commented Mar 13, 2021

Yea, sure, but could you provide a use case?

@rowrowrowrow
Copy link
Contributor Author

rowrowrowrow commented Mar 16, 2021

Of course and thanks!

I'd like to modify portions of state before they are sent depending on whether broadcastchannel is available and don't have a feasible way to separate those pieces otherwise. I.e. if there will be storage limitations that prevent the sending and receiving via the fallbacks for broadcastchannel.

@rowrowrowrow
Copy link
Contributor Author

@aohua I see a few issues that might cause someone to want to modify an action before it's shared. Namely general performance, storage limitations when broadcast channel isn't available, and the structured clone algorithm causing errors if some part of an action is not clonable.

rowrowrowrow added a commit to rowrowrowrow/redux-state-sync that referenced this issue Feb 14, 2022
rowrowrowrow added a commit to rowrowrowrow/redux-state-sync that referenced this issue Feb 14, 2022
rowrowrowrow added a commit to rowrowrowrow/redux-state-sync that referenced this issue Feb 15, 2022
rowrowrowrow added a commit to rowrowrowrow/redux-state-sync that referenced this issue Feb 15, 2022
@rowrowrowrow
Copy link
Contributor Author

@aohua bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants