Changed request type to a Post-Request, for the current Slack oauth interface #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, any news on when we can expect the merge and build to occur for this? I'm really hoping to utilize Slack for authentication to my new wiki but am blocked by this the issue that this resolves. Thanks!! |
|
Bumping this, facing a similar issue, please review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @aoberoi,
thank you for your great package.
On the search to find the origin for this issue: requarks/wiki#3149, I recognized that the Slack oauth, actual needs a POST-Request to work: https://api.slack.com/methods/users.identity
This little change should fix the issue.
I hope you have time to merge and build a new version.
Thank you a lot