Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update dompdf #38

Open
Triskal opened this issue Oct 18, 2022 · 2 comments
Open

Please update dompdf #38

Triskal opened this issue Oct 18, 2022 · 2 comments

Comments

@Triskal
Copy link

Triskal commented Oct 18, 2022

I added this plugin to an empty Wordpress instance and tested it with PHP 8.1. It worked without issues. However, another project that had this plugin already, broke down with PHP 8.1. The issue has to do with dompdf trying to pass a null value as an argument to file_get_contents. I do not know why the issue presents itself in one instance and not the other, since the dompdf version is supposed to be the same in both. However, the issue is very easily fixed by just updating the packages.

@Triskal
Copy link
Author

Triskal commented Oct 18, 2022

Oh, another thing: I have on two occasions now encountered the plugin also causing a fatal error, because DOMPDF_DEFAULT_PAPER_SIZE is not defined. This can be fixed by adding define('DOMPDF_DEFAULT_PAPER_SIZE', 'a4'); to wp-config.php, but properly fixing it would be preferrable.

@Triskal Triskal closed this as completed Oct 18, 2022
@Triskal Triskal reopened this Oct 18, 2022
@trevorbicewebdesign
Copy link

trevorbicewebdesign commented Oct 28, 2023

I am not affiliated with this project, but I had to update dompdf so I could use this plugin on a project I manage. I forked and opened a PR for those changes but I haven't seen any activity from the plugin developers. Anyway, here's the PR: #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants