Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handler should be static #7

Open
OuterObsessionSoftware opened this issue Dec 10, 2019 · 0 comments
Open

Handler should be static #7

OuterObsessionSoftware opened this issue Dec 10, 2019 · 0 comments

Comments

@OuterObsessionSoftware
Copy link

The following handler should really be static:

private Handler mHandler = new Handler() {
        public void handleMessage(Message m) {
            if (mRunning) {
                updateText(SystemClock.elapsedRealtime());
                dispatchChronometerTick();
                sendMessageDelayed(Message.obtain(this , TICK_WHAT),
                        100);
            }
        }
    };

For accessing the UI you could consider using weakreferences.

Other then that looks pretty good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant