From f1b26803d96f5fb7d0117ccdc989f7166b5350d8 Mon Sep 17 00:00:00 2001 From: Anton B Date: Wed, 6 Sep 2023 15:26:44 -0300 Subject: [PATCH 01/25] ci: upload blob reports when any of the tests ran and always expose PR data --- .github/workflows/automated-tests.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index b86ca1213a12..2c6d4c789b2f 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -269,7 +269,8 @@ jobs: npx playwright install-deps npx playwright install ' - - name: Run tests + - name: Run Chromium tests + id: chromium-tests working-directory: ./bigbluebutton-tests/playwright env: NODE_EXTRA_CA_CERTS: /usr/local/share/ca-certificates/bbb-dev/bbb-dev-ca.crt @@ -278,6 +279,7 @@ jobs: BBB_SECRET: bbbci run: npm run test-chromium-ci -- --shard ${{ matrix.shard }} - name: Run Firefox tests + id: firefox-tests working-directory: ./bigbluebutton-tests/playwright if: | contains(github.event.pull_request.labels.*.name, 'test Firefox') || @@ -293,7 +295,7 @@ jobs: find $HOME/.cache/ms-playwright -name libnssckbi.so -exec rm {} \; -exec ln -s /usr/lib/x86_64-linux-gnu/pkcs11/p11-kit-trust.so {} \; npm run test-firefox-ci -- --shard ${{ matrix.shard }} ' - - if: always() && github.event_name == 'pull_request' + - if: always() && github.event_name == 'pull_request' && (steps.chromium-tests.conclusion != 'skipped' || steps.firefox-tests.conclusion != 'skipped') name: Upload blob report to GitHub Actions Artifacts uses: actions/upload-artifact@v3 with: @@ -362,14 +364,14 @@ jobs: bigbluebutton-tests/playwright/playwright-report bigbluebutton-tests/playwright/test-results - name: Write PR data for auto-comment - if: github.event_name == 'pull_request' + if: always() && github.event_name == 'pull_request' working-directory: ./ run: | mkdir -p ./pr-comment-data echo ${{ github.event.number }} > ./pr-comment-data/pr_number echo ${{ github.run_id }} > ./pr-comment-data/workflow_id - name: Upload PR data for auto-comment - if: github.event_name == 'pull_request' + if: always() && github.event_name == 'pull_request' uses: actions/upload-artifact@v3 with: name: pr-comment-data From f2c7240b23e505b85e9883fd36da6a722d4a9bc1 Mon Sep 17 00:00:00 2001 From: Anton B Date: Wed, 6 Sep 2023 17:55:43 -0300 Subject: [PATCH 02/25] ci: expose failure reason --- .github/workflows/automated-tests.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index 2c6d4c789b2f..2587e3f6f1b8 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -103,6 +103,11 @@ jobs: with: name: artifacts_${{ matrix.package }}.tar path: artifacts.tar + - if: failure() + run: | + mkdir -p ./pr-comment-data + echo "build-package" > ./pr-comment-data/failure-reason + echo ${{ matrix.package }} >> ./pr-comment-data/failed-builds install-and-run-tests: needs: build-package runs-on: ubuntu-22.04 @@ -261,6 +266,10 @@ jobs: sed -i "s/\"minify\": true,/\"minify\": false,/" /usr/share/etherpad-lite/settings.json bbb-conf --restart EOF + - if: failure() + run: | + mkdir -p ./pr-comment-data + echo "bbb-installation" > ./pr-comment-data/failure-reason - name: Install test dependencies working-directory: ./bigbluebutton-tests/playwright run: | From 4914127071a27ad9c273797d8885d43b36a9faa6 Mon Sep 17 00:00:00 2001 From: Anton B Date: Wed, 6 Sep 2023 18:28:58 -0300 Subject: [PATCH 03/25] ci: fix working-directory --- .github/workflows/automated-tests.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index 2587e3f6f1b8..ed0bc149f2ea 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -104,6 +104,7 @@ jobs: name: artifacts_${{ matrix.package }}.tar path: artifacts.tar - if: failure() + working-directory: ./ run: | mkdir -p ./pr-comment-data echo "build-package" > ./pr-comment-data/failure-reason @@ -267,6 +268,7 @@ jobs: bbb-conf --restart EOF - if: failure() + working-directory: ./ run: | mkdir -p ./pr-comment-data echo "bbb-installation" > ./pr-comment-data/failure-reason From a483d2dc2223b284f6d489abc4174a39ee759136 Mon Sep 17 00:00:00 2001 From: Anton B Date: Thu, 7 Sep 2023 11:55:03 -0300 Subject: [PATCH 04/25] ci: upload files when there's a failure --- .github/workflows/automated-tests.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index ed0bc149f2ea..ad6a1c8edcd1 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -109,6 +109,11 @@ jobs: mkdir -p ./pr-comment-data echo "build-package" > ./pr-comment-data/failure-reason echo ${{ matrix.package }} >> ./pr-comment-data/failed-builds + - if: failure() + uses: actions/upload-artifact@v3 + with: + name: pr-comment-data + path: pr-comment-data install-and-run-tests: needs: build-package runs-on: ubuntu-22.04 From 27cb86cd698a8a6c45865b85aeb358794ddc994e Mon Sep 17 00:00:00 2001 From: Anton B Date: Mon, 11 Sep 2023 10:56:31 -0300 Subject: [PATCH 05/25] ci: check downloaded failure reason --- .github/workflows/automated-tests.yml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index ad6a1c8edcd1..90c1e3def0be 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -364,15 +364,31 @@ jobs: - name: Install dependencies working-directory: ./bigbluebutton-tests/playwright run: npm ci + - if: needs.install-and-run-tests.result == 'failure' + id: pr-data-artifact + uses: actions/download-artifact@v3 + with: + name: pr-comment-data + - if: steps.pr-data-artifact.outcome == 'success' + id: failure-check + run: | + if [ -f "./pr-comment-data/failure-reason" ]; then + echo "isAutomatedTestFailure=false" >> $GITHUB_OUTPUT + else + echo "isAutomatedTestFailure=true" >> $GITHUB_OUTPUT + fi - name: Download all blob reports from GitHub Actions Artifacts + if: needs.install-and-run-tests.result == 'skipped' || !steps.failure-check.outputs.isAutomatedTestFailure uses: actions/download-artifact@v3 with: name: all-blob-reports path: bigbluebutton-tests/playwright/all-blob-reports - name: Merge into HTML Report + if: needs.install-and-run-tests.result == 'skipped' || !steps.failure-check.outputs.isAutomatedTestFailure working-directory: ./bigbluebutton-tests/playwright run: npx playwright merge-reports --reporter html ./all-blob-reports - name: Upload HTML tests report + if: needs.install-and-run-tests.result == 'skipped' || !steps.failure-check.outputs.isAutomatedTestFailure uses: actions/upload-artifact@v3 with: name: tests-report From 8ce6c2fab4727b8e3b997e5a918f8b235d233bb0 Mon Sep 17 00:00:00 2001 From: Anton B Date: Fri, 15 Sep 2023 12:48:00 -0300 Subject: [PATCH 06/25] ci: additional contidion for downloading pr-data-artifacts --- .github/workflows/automated-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index 90c1e3def0be..1140d1840a1f 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -364,7 +364,7 @@ jobs: - name: Install dependencies working-directory: ./bigbluebutton-tests/playwright run: npm ci - - if: needs.install-and-run-tests.result == 'failure' + - if: needs.install-and-run-tests.result == 'skipped' || needs.install-and-run-tests.result == 'failure' id: pr-data-artifact uses: actions/download-artifact@v3 with: From 8a93d02214663b5286d0f2d361b76968b72ee2be Mon Sep 17 00:00:00 2001 From: Anton B Date: Fri, 15 Sep 2023 14:26:36 -0300 Subject: [PATCH 07/25] ci: fix conditions --- .github/workflows/automated-tests.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index 1140d1840a1f..c2cfb72e0f1c 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -372,23 +372,24 @@ jobs: - if: steps.pr-data-artifact.outcome == 'success' id: failure-check run: | + # "failure-reason" file is created for build and installation failure only if [ -f "./pr-comment-data/failure-reason" ]; then echo "isAutomatedTestFailure=false" >> $GITHUB_OUTPUT else echo "isAutomatedTestFailure=true" >> $GITHUB_OUTPUT fi - name: Download all blob reports from GitHub Actions Artifacts - if: needs.install-and-run-tests.result == 'skipped' || !steps.failure-check.outputs.isAutomatedTestFailure + if: steps.failure-check.outputs.isAutomatedTestFailure uses: actions/download-artifact@v3 with: name: all-blob-reports path: bigbluebutton-tests/playwright/all-blob-reports - name: Merge into HTML Report - if: needs.install-and-run-tests.result == 'skipped' || !steps.failure-check.outputs.isAutomatedTestFailure + if: steps.failure-check.outputs.isAutomatedTestFailure working-directory: ./bigbluebutton-tests/playwright run: npx playwright merge-reports --reporter html ./all-blob-reports - name: Upload HTML tests report - if: needs.install-and-run-tests.result == 'skipped' || !steps.failure-check.outputs.isAutomatedTestFailure + if: steps.failure-check.outputs.isAutomatedTestFailure uses: actions/upload-artifact@v3 with: name: tests-report From ebb2b5e64fc43a396732c65a206ddbcc1db1ba52 Mon Sep 17 00:00:00 2001 From: Anton Barboza Date: Mon, 25 Sep 2023 09:27:25 -0300 Subject: [PATCH 08/25] echoing file content --- .github/workflows/automated-tests.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index c2cfb72e0f1c..a1be4458631d 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -374,22 +374,23 @@ jobs: run: | # "failure-reason" file is created for build and installation failure only if [ -f "./pr-comment-data/failure-reason" ]; then + echo ./pr-comment-data/failure-reason echo "isAutomatedTestFailure=false" >> $GITHUB_OUTPUT else echo "isAutomatedTestFailure=true" >> $GITHUB_OUTPUT fi - name: Download all blob reports from GitHub Actions Artifacts - if: steps.failure-check.outputs.isAutomatedTestFailure + if: ${{ steps.failure-check.outputs.isAutomatedTestFailure }} uses: actions/download-artifact@v3 with: name: all-blob-reports path: bigbluebutton-tests/playwright/all-blob-reports - name: Merge into HTML Report - if: steps.failure-check.outputs.isAutomatedTestFailure + if: ${{ steps.failure-check.outputs.isAutomatedTestFailure }} working-directory: ./bigbluebutton-tests/playwright run: npx playwright merge-reports --reporter html ./all-blob-reports - name: Upload HTML tests report - if: steps.failure-check.outputs.isAutomatedTestFailure + if: ${{ steps.failure-check.outputs.isAutomatedTestFailure }} uses: actions/upload-artifact@v3 with: name: tests-report From 89000aadff97ee4e1e38b4127fe8fede9b578a37 Mon Sep 17 00:00:00 2001 From: Anton Barboza Date: Mon, 25 Sep 2023 10:05:47 -0300 Subject: [PATCH 09/25] fix conditional check --- .github/workflows/automated-tests.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index a1be4458631d..cc73760db336 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -375,22 +375,22 @@ jobs: # "failure-reason" file is created for build and installation failure only if [ -f "./pr-comment-data/failure-reason" ]; then echo ./pr-comment-data/failure-reason - echo "isAutomatedTestFailure=false" >> $GITHUB_OUTPUT + echo "isAutomatedTestFailure='false'" >> $GITHUB_OUTPUT else - echo "isAutomatedTestFailure=true" >> $GITHUB_OUTPUT + echo "isAutomatedTestFailure='true'" >> $GITHUB_OUTPUT fi - name: Download all blob reports from GitHub Actions Artifacts - if: ${{ steps.failure-check.outputs.isAutomatedTestFailure }} + if: steps.failure-check.outputs.isAutomatedTestFailure == 'true' uses: actions/download-artifact@v3 with: name: all-blob-reports path: bigbluebutton-tests/playwright/all-blob-reports - name: Merge into HTML Report - if: ${{ steps.failure-check.outputs.isAutomatedTestFailure }} + if: steps.failure-check.outputs.isAutomatedTestFailure == 'true' working-directory: ./bigbluebutton-tests/playwright run: npx playwright merge-reports --reporter html ./all-blob-reports - name: Upload HTML tests report - if: ${{ steps.failure-check.outputs.isAutomatedTestFailure }} + if: steps.failure-check.outputs.isAutomatedTestFailure == 'true' uses: actions/upload-artifact@v3 with: name: tests-report From e7875b4f78948b8008e67ccf60bdcd8c5fd6b342 Mon Sep 17 00:00:00 2001 From: Anton Barboza Date: Mon, 25 Sep 2023 11:58:12 -0300 Subject: [PATCH 10/25] forces failure on bbb-playback build --- .github/workflows/automated-tests.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index cc73760db336..5f583644edd0 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -74,6 +74,8 @@ jobs: - package: others build-list: bbb-mkclean bbb-pads bbb-libreoffice-docker bbb-transcription-controller bigbluebutton steps: + - if: ${{ matrix.package == 'bbb-playback-record' }} + run: exit 1 - uses: actions/checkout@v3 - name: Merge branches uses: ./.github/actions/merge-branches From bb4164b3ae9c2e0ca1b56dc95272f381452fac10 Mon Sep 17 00:00:00 2001 From: Anton Barboza Date: Mon, 25 Sep 2023 17:49:25 -0300 Subject: [PATCH 11/25] trying with quotes --- .github/workflows/automated-tests.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index 5f583644edd0..6541dbb868de 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -110,7 +110,7 @@ jobs: run: | mkdir -p ./pr-comment-data echo "build-package" > ./pr-comment-data/failure-reason - echo ${{ matrix.package }} >> ./pr-comment-data/failed-builds + echo "${{ matrix.package }}" >> ./pr-comment-data/failed-builds - if: failure() uses: actions/upload-artifact@v3 with: @@ -406,6 +406,7 @@ jobs: mkdir -p ./pr-comment-data echo ${{ github.event.number }} > ./pr-comment-data/pr_number echo ${{ github.run_id }} > ./pr-comment-data/workflow_id + cat ./pr-comment-data/failed-builds - name: Upload PR data for auto-comment if: always() && github.event_name == 'pull_request' uses: actions/upload-artifact@v3 From ca9af1c7377f93bccd2799c64c95977b930ea6c2 Mon Sep 17 00:00:00 2001 From: Anton Barboza Date: Mon, 25 Sep 2023 20:24:47 -0300 Subject: [PATCH 12/25] create different files for each failed build --- .github/workflows/automated-tests.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index 6541dbb868de..3a5982fd8098 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -110,7 +110,8 @@ jobs: run: | mkdir -p ./pr-comment-data echo "build-package" > ./pr-comment-data/failure-reason - echo "${{ matrix.package }}" >> ./pr-comment-data/failed-builds + mkdir -p ./pr-comment-data/failed-builds + echo "${{ matrix.package }}" >> ./pr-comment-data/failed-builds/build_${{ matrix.shard }} - if: failure() uses: actions/upload-artifact@v3 with: @@ -376,11 +377,13 @@ jobs: run: | # "failure-reason" file is created for build and installation failure only if [ -f "./pr-comment-data/failure-reason" ]; then - echo ./pr-comment-data/failure-reason + cat ./pr-comment-data/failure-reason echo "isAutomatedTestFailure='false'" >> $GITHUB_OUTPUT else echo "isAutomatedTestFailure='true'" >> $GITHUB_OUTPUT fi + - if: steps.failure-check.outcome == 'success' && steps.failure-check.outputs.isAutomatedTestFailure != 'true' + run: cat ./pr-comment-data/failed-builds - name: Download all blob reports from GitHub Actions Artifacts if: steps.failure-check.outputs.isAutomatedTestFailure == 'true' uses: actions/download-artifact@v3 From 77e45c7343a5d40f004f6aa106f85d4871186226 Mon Sep 17 00:00:00 2001 From: Anton Barboza Date: Mon, 25 Sep 2023 20:33:27 -0300 Subject: [PATCH 13/25] fix --- .github/workflows/automated-tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index 3a5982fd8098..9050acd4089a 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -377,13 +377,13 @@ jobs: run: | # "failure-reason" file is created for build and installation failure only if [ -f "./pr-comment-data/failure-reason" ]; then - cat ./pr-comment-data/failure-reason + cat ~/pr-comment-data/failure-reason echo "isAutomatedTestFailure='false'" >> $GITHUB_OUTPUT else echo "isAutomatedTestFailure='true'" >> $GITHUB_OUTPUT fi - if: steps.failure-check.outcome == 'success' && steps.failure-check.outputs.isAutomatedTestFailure != 'true' - run: cat ./pr-comment-data/failed-builds + run: cat ~/pr-comment-data/failed-builds - name: Download all blob reports from GitHub Actions Artifacts if: steps.failure-check.outputs.isAutomatedTestFailure == 'true' uses: actions/download-artifact@v3 From 5f6ff6363c9725713e8709c24de5452fb2761a65 Mon Sep 17 00:00:00 2001 From: Anton Barboza Date: Mon, 25 Sep 2023 20:56:32 -0300 Subject: [PATCH 14/25] unzip downloaded files --- .github/workflows/automated-tests.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index 9050acd4089a..f4109e36181d 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -375,8 +375,9 @@ jobs: - if: steps.pr-data-artifact.outcome == 'success' id: failure-check run: | + unzip pr-comment-data # "failure-reason" file is created for build and installation failure only - if [ -f "./pr-comment-data/failure-reason" ]; then + if [ -f "~/pr-comment-data/failure-reason" ]; then cat ~/pr-comment-data/failure-reason echo "isAutomatedTestFailure='false'" >> $GITHUB_OUTPUT else From 85b79c91eb4e2afc32f181bd46333f3025dc9798 Mon Sep 17 00:00:00 2001 From: Anton Barboza Date: Mon, 25 Sep 2023 20:59:23 -0300 Subject: [PATCH 15/25] fix directory --- .github/workflows/automated-tests.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index f4109e36181d..9931c63cd148 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -377,14 +377,15 @@ jobs: run: | unzip pr-comment-data # "failure-reason" file is created for build and installation failure only - if [ -f "~/pr-comment-data/failure-reason" ]; then - cat ~/pr-comment-data/failure-reason + if [ -f "./pr-comment-data/failure-reason" ]; then + cat ./pr-comment-data/failure-reason echo "isAutomatedTestFailure='false'" >> $GITHUB_OUTPUT else echo "isAutomatedTestFailure='true'" >> $GITHUB_OUTPUT fi - if: steps.failure-check.outcome == 'success' && steps.failure-check.outputs.isAutomatedTestFailure != 'true' - run: cat ~/pr-comment-data/failed-builds + # for loop here later + run: cat ./pr-comment-data/failed-builds - name: Download all blob reports from GitHub Actions Artifacts if: steps.failure-check.outputs.isAutomatedTestFailure == 'true' uses: actions/download-artifact@v3 From 0d67d413005966c6a1d0b0a74bf18405f39efb7c Mon Sep 17 00:00:00 2001 From: Anton Barboza Date: Mon, 25 Sep 2023 21:10:41 -0300 Subject: [PATCH 16/25] add debug commands --- .github/workflows/automated-tests.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index 9931c63cd148..77f81e24d63a 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -375,6 +375,11 @@ jobs: - if: steps.pr-data-artifact.outcome == 'success' id: failure-check run: | + echo "opa" + pwd + echo "opa 2" + ls -R + echo "opa 3" unzip pr-comment-data # "failure-reason" file is created for build and installation failure only if [ -f "./pr-comment-data/failure-reason" ]; then From eba277c444085337b42ae635a8e00cb13a1bb540 Mon Sep 17 00:00:00 2001 From: Anton Barboza Date: Mon, 25 Sep 2023 21:25:20 -0300 Subject: [PATCH 17/25] fixx --- .github/workflows/automated-tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index 77f81e24d63a..a062ebe30a91 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -372,15 +372,15 @@ jobs: uses: actions/download-artifact@v3 with: name: pr-comment-data + path: pr-comment-data - if: steps.pr-data-artifact.outcome == 'success' id: failure-check run: | echo "opa" pwd echo "opa 2" - ls -R + ls echo "opa 3" - unzip pr-comment-data # "failure-reason" file is created for build and installation failure only if [ -f "./pr-comment-data/failure-reason" ]; then cat ./pr-comment-data/failure-reason From 7d00f98cf54d54a75ef535a9cb66b673dd849ec8 Mon Sep 17 00:00:00 2001 From: Anton Barboza Date: Mon, 25 Sep 2023 21:34:26 -0300 Subject: [PATCH 18/25] fix wrong cat --- .github/workflows/automated-tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index a062ebe30a91..86f826b1e6a8 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -390,7 +390,7 @@ jobs: fi - if: steps.failure-check.outcome == 'success' && steps.failure-check.outputs.isAutomatedTestFailure != 'true' # for loop here later - run: cat ./pr-comment-data/failed-builds + run: ls ./pr-comment-data/failed-builds - name: Download all blob reports from GitHub Actions Artifacts if: steps.failure-check.outputs.isAutomatedTestFailure == 'true' uses: actions/download-artifact@v3 @@ -416,7 +416,7 @@ jobs: mkdir -p ./pr-comment-data echo ${{ github.event.number }} > ./pr-comment-data/pr_number echo ${{ github.run_id }} > ./pr-comment-data/workflow_id - cat ./pr-comment-data/failed-builds + ls ./pr-comment-data/failed-builds - name: Upload PR data for auto-comment if: always() && github.event_name == 'pull_request' uses: actions/upload-artifact@v3 From 97c5b3ade50fbd67825a17a7fa829106237074a3 Mon Sep 17 00:00:00 2001 From: Anton Barboza Date: Mon, 25 Sep 2023 21:46:48 -0300 Subject: [PATCH 19/25] use separate files instead an unique with all failed builds --- .github/workflows/automated-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index 86f826b1e6a8..8e73de2e58d9 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -111,7 +111,7 @@ jobs: mkdir -p ./pr-comment-data echo "build-package" > ./pr-comment-data/failure-reason mkdir -p ./pr-comment-data/failed-builds - echo "${{ matrix.package }}" >> ./pr-comment-data/failed-builds/build_${{ matrix.shard }} + touch ./pr-comment-data/failed-builds/${{ matrix.package }} - if: failure() uses: actions/upload-artifact@v3 with: From d5cc9cf2573fecc241e22a2104ea035c4585bb23 Mon Sep 17 00:00:00 2001 From: Anton Barboza Date: Mon, 25 Sep 2023 21:58:16 -0300 Subject: [PATCH 20/25] wip --- .github/workflows/automated-tests.yml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index 8e73de2e58d9..5cf138d1224e 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -376,11 +376,6 @@ jobs: - if: steps.pr-data-artifact.outcome == 'success' id: failure-check run: | - echo "opa" - pwd - echo "opa 2" - ls - echo "opa 3" # "failure-reason" file is created for build and installation failure only if [ -f "./pr-comment-data/failure-reason" ]; then cat ./pr-comment-data/failure-reason @@ -390,7 +385,7 @@ jobs: fi - if: steps.failure-check.outcome == 'success' && steps.failure-check.outputs.isAutomatedTestFailure != 'true' # for loop here later - run: ls ./pr-comment-data/failed-builds + run: - name: Download all blob reports from GitHub Actions Artifacts if: steps.failure-check.outputs.isAutomatedTestFailure == 'true' uses: actions/download-artifact@v3 From 22218c1508375fc86823ccf526657317900e6276 Mon Sep 17 00:00:00 2001 From: Anton Barboza Date: Tue, 26 Sep 2023 08:38:30 -0300 Subject: [PATCH 21/25] fix where is save failed packages --- .github/workflows/automated-tests.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index 5cf138d1224e..d062c2d013a4 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -384,8 +384,8 @@ jobs: echo "isAutomatedTestFailure='true'" >> $GITHUB_OUTPUT fi - if: steps.failure-check.outcome == 'success' && steps.failure-check.outputs.isAutomatedTestFailure != 'true' - # for loop here later - run: + working-directory: pr-comment-data/failed-builds + run: for pckg in *; do echo "
  • $pckg
    • " >> ./failed-packages; done; - name: Download all blob reports from GitHub Actions Artifacts if: steps.failure-check.outputs.isAutomatedTestFailure == 'true' uses: actions/download-artifact@v3 @@ -411,7 +411,6 @@ jobs: mkdir -p ./pr-comment-data echo ${{ github.event.number }} > ./pr-comment-data/pr_number echo ${{ github.run_id }} > ./pr-comment-data/workflow_id - ls ./pr-comment-data/failed-builds - name: Upload PR data for auto-comment if: always() && github.event_name == 'pull_request' uses: actions/upload-artifact@v3 From 842abea1e606e7e03a6b7497b1314f1bcc9507b6 Mon Sep 17 00:00:00 2001 From: Anton Barboza Date: Tue, 26 Sep 2023 08:54:01 -0300 Subject: [PATCH 22/25] trigger workflow --- .github/workflows/automated-tests.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index d062c2d013a4..7cd6621661d9 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -385,7 +385,10 @@ jobs: fi - if: steps.failure-check.outcome == 'success' && steps.failure-check.outputs.isAutomatedTestFailure != 'true' working-directory: pr-comment-data/failed-builds - run: for pckg in *; do echo "
  • $pckg
    • " >> ./failed-packages; done; + run: | + for pckg in *; do echo "
  • $pckg
    • " >> ./failed-packages; done; + pwd + ls - name: Download all blob reports from GitHub Actions Artifacts if: steps.failure-check.outputs.isAutomatedTestFailure == 'true' uses: actions/download-artifact@v3 @@ -411,6 +414,8 @@ jobs: mkdir -p ./pr-comment-data echo ${{ github.event.number }} > ./pr-comment-data/pr_number echo ${{ github.run_id }} > ./pr-comment-data/workflow_id + pwd + ls -R - name: Upload PR data for auto-comment if: always() && github.event_name == 'pull_request' uses: actions/upload-artifact@v3 From 4870bfed0c5cc637eeffa77fccf95a28c55d2e6c Mon Sep 17 00:00:00 2001 From: Anton Barboza Date: Tue, 26 Sep 2023 23:13:24 -0300 Subject: [PATCH 23/25] trigger --- .github/workflows/automated-tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index 7cd6621661d9..4e1d0a83cb47 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -414,6 +414,7 @@ jobs: mkdir -p ./pr-comment-data echo ${{ github.event.number }} > ./pr-comment-data/pr_number echo ${{ github.run_id }} > ./pr-comment-data/workflow_id + echo "content" > ./pr-comment-data/test pwd ls -R - name: Upload PR data for auto-comment From 9e7fa14170c7cdcedeefe1ecc6b4ded0dcd4a6e4 Mon Sep 17 00:00:00 2001 From: Anton Barboza Date: Tue, 26 Sep 2023 23:15:35 -0300 Subject: [PATCH 24/25] trigger2 --- .github/workflows/automated-tests.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index 4e1d0a83cb47..e5adb72dfa04 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -417,6 +417,8 @@ jobs: echo "content" > ./pr-comment-data/test pwd ls -R + echo "==" + ls ./pr-comment-data - name: Upload PR data for auto-comment if: always() && github.event_name == 'pull_request' uses: actions/upload-artifact@v3 From f5db1edafe92d659cd0bec4270ea8f1a1ff76b8b Mon Sep 17 00:00:00 2001 From: Anton Barboza Date: Wed, 27 Sep 2023 00:31:32 -0300 Subject: [PATCH 25/25] fix echo --- .github/workflows/automated-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/automated-tests.yml b/.github/workflows/automated-tests.yml index e5adb72dfa04..3e50f707e87f 100644 --- a/.github/workflows/automated-tests.yml +++ b/.github/workflows/automated-tests.yml @@ -386,7 +386,7 @@ jobs: - if: steps.failure-check.outcome == 'success' && steps.failure-check.outputs.isAutomatedTestFailure != 'true' working-directory: pr-comment-data/failed-builds run: | - for pckg in *; do echo "
  • $pckg
    • " >> ./failed-packages; done; + for pckg in *; do echo -e "
  • $pckg
    • " >> ./failed-packages; done; pwd ls - name: Download all blob reports from GitHub Actions Artifacts