Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding PHP 8.0 version support #26

Open
peter279k opened this issue Nov 19, 2021 · 1 comment · May be fixed by #31
Open

Consider adding PHP 8.0 version support #26

peter279k opened this issue Nov 19, 2021 · 1 comment · May be fixed by #31
Assignees
@kpicaza
Labels
question Further information is requested

Comments

@peter279k
Copy link
Member

As title, since many other PHP packages on this organization support PHP-7.4 and PHP-8.0 version now, this installer package I think should support PHP-8.0 version, too.

If this issue is accepted, I can help to work on that and some works need to be resolved:

  • Letting "php": "^7.4.0", definition be "php": "^7.4|^8.0", inside require setting on composer.json file.
  • Adding 8.0 on coding-standards.yml, mutation-tests.yml, phpunit.yml and psalm.yml files.
@peter279k peter279k added the question Further information is requested label Nov 19, 2021
@peter279k peter279k changed the title Consider add ing PHP 8.0 version support Consider adding PHP 8.0 version support Nov 19, 2021
@kpicaza
Copy link
Member

kpicaza commented Nov 20, 2021

Thanks @peter279k, I'm 100% agree. We can go for it 🚀.

@peter279k peter279k linked a pull request Nov 26, 2021 that will close this issue
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpicaza kpicaza

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolves issue#26 open-source-contributions/installer
2 participants
@kpicaza @peter279k