Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle incorrect git remote #58

Open
5 of 7 tasks
privatenumber opened this issue Nov 6, 2024 · 0 comments
Open
5 of 7 tasks

Handle incorrect git remote #58

privatenumber opened this issue Nov 6, 2024 · 0 comments
Labels
enhancement New feature or request pr welcome

Comments

@privatenumber
Copy link
Member

Describe the bug

Previously, I was an external contributor to https://github.com/antfu-collective/sponsorkit so my git remotes looked like this:

  • origin: my fork
  • up: original repo

When I was given permission to do releases, bumpp pushed the tag to origin, which didn't correctly handle the release because it's my fork.

I'm thinking it should cross check that git remote origin matches the repo in package.json and error if not.

Reproduction

N/A

System Info

N/A

Used Package Manager

npm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.

Contributions

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)
@antfu antfu added enhancement New feature or request pr welcome labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pr welcome
Projects
None yet
Development

No branches or pull requests

2 participants