Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that RecoverMiddleware does not catch log.Fatal #175

Open
ant0ine opened this issue Jan 18, 2016 · 0 comments
Open

Document that RecoverMiddleware does not catch log.Fatal #175

ant0ine opened this issue Jan 18, 2016 · 0 comments
Labels
enhancement

Comments

@ant0ine
Copy link
Owner

ant0ine commented Jan 18, 2016

From the doc:

Fatal is equivalent to Print() followed by a call to os.Exit(1).

recoverMiddleware recovers from panic, not from os.Exit, and that should be documented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ant0ine