Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CONTROL_TIMESTEP and CONTROL_TIME_STEP (#629) #631

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: CONTROL_TIMESTEP and CONTROL_TIME_STEP (#629) #631

wants to merge 4 commits into from
+377 −11

Conversation

RaphaelHeiniger
Copy link
Collaborator

CONTROL_TIMESTEP, CONTROL_TIMESTEP is in the kwd.json now and should be generated. Removed it from the SKIPPED_KEYWORDS list. Removed it from manifest. Added test for CONTROL_TIMESTEP and edited test for CONTROL_TIME_STEP.

@RaphaelHeiniger
CONTROL_TIMESTEP, CONTROL_TIMESTEP is in the kwd.json now and should …
aedbc98 
…be generated. Removed it from the SKIPPED_KEYWORDS list. Removed it from manifest. Added test for CONTROL_TIMESTEP and edited test for CONTROL_TIME_STEP.
@RaphaelHeiniger RaphaelHeiniger requested a review from a team as a code owner November 28, 2024 13:31
@RaphaelHeiniger RaphaelHeiniger linked an issue Nov 28, 2024 that may be closed by this pull request
ansys.dyna.core.keywords.keyword_classes' has no attribute 'ControlTimestep' #629
Open
2 tasks
@github-actions github-actions bot added documentation Improvements or additions to documentation testing Anything related to testing labels Nov 28, 2024
@RaphaelHeiniger
Copy link
Collaborator Author

@RobPasMue can you advise me on how to label the pull request. Thanks.

@RaphaelHeiniger RaphaelHeiniger changed the title Fix for issue #629 CONTROL_TIMESTEP ... fix: CONTROL_TIMESTEP and CONTROL_TIME_STEP (#629) Nov 28, 2024
RobPasMue
RobPasMue reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should be labeled as an enhancement. Also, I'd leave it to the rest of the @ansys/pydyna team to review it since I am no expert on these modules...

src/ansys/dyna/core/keywords/keyword_classes/auto_keywords.py Show resolved Hide resolved
src/ansys/dyna/core/keywords/keyword_classes/auto/control_time_step.py Show resolved Hide resolved
@RaphaelHeiniger RaphaelHeiniger added enhancement New features or code improvements and removed documentation Improvements or additions to documentation labels Nov 28, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 6, 2024
@koubaa
Copy link
Collaborator

koubaa commented Dec 20, 2024

@RaphaelHeiniger please go ahead and merge

@koubaa koubaa requested a review from RobPasMue December 20, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koubaa koubaa koubaa approved these changes

@RobPasMue RobPasMue Awaiting requested review from RobPasMue

Assignees

@koubaa koubaa

Labels
documentation Improvements or additions to documentation enhancement New features or code improvements testing Anything related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ansys.dyna.core.keywords.keyword_classes' has no attribute 'ControlTimestep'
4 participants
@RaphaelHeiniger @koubaa @RobPasMue @pyansys-ci-bot