Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Model from a StreamsContainer #2032

Open
PProfizi opened this issue Jan 22, 2025 · 1 comment
Open

Create Model from a StreamsContainer #2032

PProfizi opened this issue Jan 22, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@PProfizi
Copy link
Contributor

Description of the feature

When defining a specific behavior for a StreamsProvider, the StreamsContainer in output currently cannot be used to instantiate a Model.
The enhancement would be to accept a StreamsContainer when creating a Model.

@MeenaBytes @ahernsean

I know that other improvements to better handle the behavior of the readers is necessary, maybe at the DataSources level. We can discuss this in other issues.

Steps for implementing the feature

Change the Model.__init__ method to accept a StreamsContainer as data_sources. The parameter already accepts an str or a os.PathLike so we might as well accept a StreamsContainer.

Useful links and references

No response

@PProfizi PProfizi added the enhancement New feature or request label Jan 22, 2025
@PProfizi PProfizi added this to the 0.13.5 milestone Jan 22, 2025
@PProfizi PProfizi self-assigned this Jan 22, 2025
@PProfizi
Copy link
Contributor Author

The remark was made that the reading settings could be something we set at the DataSources level, which then would be used to set the reading options of a StreamsProvider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant