Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHORE: SetupMaxwell refactoring to save fields and new SweepMaxwell for EC solvers #5670

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

CHORE: SetupMaxwell refactoring to save fields and new SweepMaxwell for EC solvers #5670

wants to merge 1 commit into from

Conversation

gmalinve
Copy link
Contributor

Description

**In this PR I want to:

  • Improve the SetupMaxwell class in order to be able to save fields for all solvers.
  • Add a new class in solve_sweep to handle EC freq. sweeps.
  • Add/improve the already exisiting method to add frequency sweeps for EC in order to return the sweep object.**

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@gmalinve gmalinve linked an issue Jan 17, 2025 that may be closed by this pull request
SetupMaxwell refactoring and implement SweepMaxwellEC #5658
Open
@gmalinve gmalinve self-assigned this Jan 17, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 6.06061% with 31 lines in your changes missing coverage. Please review.

Project coverage is 18.05%. Comparing base (11e2fdd) to head (5cf2d00).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #5670       +/-   ##
===========================================
- Coverage   85.23%   18.05%   -67.19%     
===========================================
  Files         154      154               
  Lines       60764    60782       +18     
===========================================
- Hits        51795    10974    -40821     
- Misses       8969    49808    +40839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcapodi78 maxcapodi78 Awaiting requested review from maxcapodi78

@Alberto-DM Alberto-DM Awaiting requested review from Alberto-DM

@Samuelopez-ansys Samuelopez-ansys Awaiting requested review from Samuelopez-ansys

@MaxJPRey MaxJPRey Awaiting requested review from MaxJPRey

@SMoraisAnsys SMoraisAnsys Awaiting requested review from SMoraisAnsys

At least 1 approving review is required to merge this pull request.

Assignees

@gmalinve gmalinve

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SetupMaxwell refactoring and implement SweepMaxwellEC
1 participant
@gmalinve