Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more than one circuit schematic page #5530

Closed
DaveTwyman opened this issue Dec 4, 2024 · 3 comments
Closed

Add support for more than one circuit schematic page #5530

DaveTwyman opened this issue Dec 4, 2024 · 3 comments
Assignees
Labels
enhancement New features or code improvements

Comments

@DaveTwyman
Copy link
Contributor

Description of the feature

Presently circuit schematic (Maxwell circuit, circuit, Simplorer etc) only allow one schematic page. Add support for having multiple pages.
Needed for ETK, Electronic Transformer Toolkit.

Steps for implementing the feature

Expose page number create_component method of primitives_circuit.py to PyAEDT

Useful links and references

No response

@DaveTwyman DaveTwyman added the enhancement New features or code improvements label Dec 4, 2024
@DaveTwyman DaveTwyman self-assigned this Dec 4, 2024
@gmalinve
Copy link
Contributor

gmalinve commented Dec 5, 2024

@DaveTwyman is this not what you have already implemented with the create_page in this PR #5283?

@DaveTwyman
Copy link
Contributor Author

@gmalinve , Not quite, when circuit elements are added the page number needs setting to have them land on the intended page if there is more than one page. UI and native API behave differently in this respect.

At the moment Pyaedt just supports all circuit elements landing on first page

@DaveTwyman
Copy link
Contributor Author

@gmalinve , Thinking about this a bit more, it would make sense if this is added at the same time as the other circuit components in R #5283 as you've pointed out.

I'll close this PR and create the new class in Schematic as discussed earlier on the Office Hours call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants