Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the inventory plugin to use an access token obtained by calling a custom URI #282

Open
rnozaki opened this issue Oct 2, 2023 · 2 comments
Labels
needs_info type/question Further information is requested

Comments

@rnozaki
Copy link
Contributor

rnozaki commented Oct 2, 2023

SUMMARY

In some environments, the access token is obtained by passing the user and password to a custom REST API.
The purpose of this request is to enable the inventory plugin to also work when the authentication is done in this 2 step approach.

  • Step 1: When a new field is present ( suggested name: token_uri, envvar: SN_TOKEN_URI), a call is made to the URI using basic authentication and an access token is obtained
  • Step 2: The access token is then used by the inventory plugin to connect to ServiceNow
ISSUE TYPE
  • Feature Idea
COMPONENT NAME

Inventory plugin.

ADDITIONAL INFORMATION
@tupyy
Copy link
Contributor

tupyy commented Feb 22, 2024

What will be the use case for that?
You can obtain an access key directly from SNow and use it in the playbook. We already support access_token.

@Akasurde Akasurde added type/question Further information is requested needs_info labels Feb 22, 2024
@rnozaki
Copy link
Contributor Author

rnozaki commented Feb 22, 2024

AAP uses the inventory plugin from servicenow.itsm to read CMDB data from ServiceNow:

  1. Standard authentication methods always worked for this (user/password)
  2. Custom method is being requested as a new feature, because the customer has a proprietary method for generating their access tokens.

This issue is a request to allow such tokens to be obtained, when optional fields like the URL for the external call is passed, and then used in the remaining of the inventory logic.

The customer has even implemented the solution for this, but Tim was going to check if adding this feature to the collection would be allowed, as this is not applicable for all users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_info type/question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants