Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nokogiri version restriction prevents use with rails 7.1 #109

Open
JoeDupuis opened this issue Jun 4, 2023 · 5 comments
Open

Nokogiri version restriction prevents use with rails 7.1 #109

JoeDupuis opened this issue Jun 4, 2023 · 5 comments

Comments

@JoeDupuis
Copy link

Rails 7.1 will be releasing this year. Rails 7.1 will require nokogiri 1.14 or higher, but ofx restrict to lower than 1.14, making it incompatible with rails 7.1.

The upper bound should be remove, that way we could control it in our own gemfile or you could merge this PR from dependabot : #108

@salex
Copy link

salex commented Jan 18, 2024

It looks like the Gem is going to be dead very soon. 1 update in two years and the latest version bombs on me.

There some older ofx parsers out there but for the hell of it I tried to replicate some of OFX. The main thing I needed was the transactions. I added Account for the heck of it.

I took a stab at it and the code is at MyOfx. Have not implemented it yet in my application but probably will soon.

@cesarjr
Copy link

cesarjr commented Jan 18, 2024

Hi @JoeDupuis!

I have a huge project that uses this gem. At this moment we're using the master content and it is working perfectly for us.

I know that it is not the ideal, but I believe that it might help you until a new version of the gem is not published.

I think the commit below may fix your problem.

# Gemfile
...
gem 'ofx', git: 'https://github.com/annacruz/ofx.git', ref: '543c18c'
...

@JoeDupuis
Copy link
Author

JoeDupuis commented Jan 20, 2024

until a new version of the gem is not published.

I'll be surprised if we ever see a new release.

So, for any future users, I am maintaining a fork of the gem that I am using in a Rails app against Rails main.
I don't intend on adding any features, just keeping the lights on.

https://github.com/JoeDupuis/ofx

@cesarjr
Copy link

cesarjr commented Jan 20, 2024

I understand your frustation, @JoeDupuis ! And I sincerely apologize if anything that I wrote contributed to it.

I simply want to attempt to maintain a single repository. I've noticed many other forks of this gem, and it can be frustrating for beginners who struggle to decide which one to choose.

Rails always had a beatiful and organized community and it was one of the points that made me starting in this one. And an incredible point of it is that generally we don't need to choose among sereval options to solve the same problem, as is often in others communities like javascript.

I don't know the specific reasons preventing the maintainer from updating the gem, but a viable alternative could be to appoint other maintainers to assist in this process.

Well, I'm going to keep waiting for an official solution and I'm really cheering for a good end.

Once again, I'm sorry if my comments got you frustrated. It was not my intention. 😞

@JoeDupuis
Copy link
Author

No worries! I was originally under the impression that you worked with the maintainer and could have nudge them to cut a release.

Sorry if my message was overly salty, we're all good 😄 My point is, we can't keep waiting, I would also like a single repo, but this one is dead 😞

but a viable alternative could be to appoint other maintainers to assist in this process.

Maybe we can reach out to the original creator. He's still an owner on RubyGems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants