Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Simulator Ignores New Cards Already Introduced #3760

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Fix: Simulator Ignores New Cards Already Introduced #3760

wants to merge 11 commits into from

Conversation

Luc-Mcgrady
Copy link
Contributor

@Luc-Mcgrady Luc-Mcgrady commented Jan 22, 2025 •
edited
Loading

fixes #3708

Where you have reviewed 4 cards today:
image

Is there a better way than using introduced:1 which doesn't include cards which have been forgotten and then re-introduced?

@brishtibheja
Copy link
Contributor

doesn't include cards which have been forgotten and then re-introduced?

can you clarify what you mean?

also, does this handle the case where learn count is lower than introduced:1?

@Luc-Mcgrady
Copy link
Contributor Author

If you have a card which has previously been introduced but then you hit "reset" on it, its introduced will still be when it was introduced the very first time. (unless its changed since I last checked)

also, does this handle the case where learn count is lower than introduced:1?

Seems to 👍
image

@brishtibheja
Copy link
Contributor

brishtibheja commented Jan 22, 2025 •
edited
Loading

If you have a card which has previously been introduced but then you hit "reset" on it, its introduced will still be when it was introduced the very first time. (unless its changed since I last checked)

only way I could think of was smth like rated:1 -rated:365 but nope, doesn't work. I guess we're fine this being only a minor issue.

@Luc-Mcgrady Luc-Mcgrady marked this pull request as ready for review January 23, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simulator Ignores New Cards Already Introduced
2 participants
@Luc-Mcgrady @brishtibheja