Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New cards ignore review limit" doesn't apply to simulator #3654

Open
brishtibheja opened this issue Dec 19, 2024 · 3 comments · Fixed by open-spaced-repetition/fsrs-rs#262

Comments

@brishtibheja
Copy link
Contributor

The setting "New cards ignore review limit" doesn't apply to the simulator.

I noticed when "Review limit" is 0 but "New card limit" is a non-zero number, the simulator shows 0 reviews for everyday, but in my case I have the said option turned on.

@L-M-Sherlock
Copy link
Contributor

@brishtibheja
Copy link
Contributor Author

@L-M-Sherlock Have you fixed this? The new cards ignore review limit toggle should work for sim.

@L-M-Sherlock
Copy link
Contributor

Nope. If the toggle should work for sim, I have to introduce a breaking change. Instead, I make the sim always behave as new cards ignore review limit is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants