Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Discard changes?" pops up when selecting desired, historical retention or FSRS parameters #3592

Open
Expertium opened this issue Nov 20, 2024 · 3 comments
Labels
web frontend Involves Anki's HTML/CSS/TypeScript/Svelte code

Comments

@Expertium
Copy link
Contributor

Expertium commented Nov 20, 2024

In Anki 24.11 (97e6b3d) the "Discard changes?" window pops up when I select the value of historical retention, desired retention or the values in the with FSRS parameters.

How to reproduce:

  1. Go to deck options
  2. Go to the field with desired retention, historical retention or FSRS parameters
  3. Select the number(s) using either the mouse or Ctrl+A
  4. Try closing deck optinos without saving
  5. See the pop up even though nothing was changed
    image
@abdnh
Copy link
Collaborator

abdnh commented Nov 25, 2024

Looks like the value 0.9 coming from the backend is arriving to the TS side as 0.8999999761581421 actually. The input boxes do some rounding that needs to be done when deciding whether there are changes.

@abdnh abdnh added the web frontend Involves Anki's HTML/CSS/TypeScript/Svelte code label Nov 25, 2024
@Expertium
Copy link
Contributor Author

I was hoping this would be fixed before 24.11. Is that too optimistic?

@dae
Copy link
Member

dae commented Nov 29, 2024

It wasn't worth holding up the release for. It can be fixed in a minor follow-up release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web frontend Involves Anki's HTML/CSS/TypeScript/Svelte code
Projects
None yet
Development

No branches or pull requests

3 participants