Fix: DeckPicker-NullPointerException in onQueryTextChange

[Giyutomioka-SS]

Purpose / Description

Fixes NullPointerException in onQueryTextChange by safely casting the adapter to Filterable before calling the filter method, preventing crashes when the adapter is null or not of the correct type.

Fixes

• Fixes DeckPicker: onQueryTextChange - NullPointerException on filter #17391

How Has This Been Tested?

Realme 6 and Emulator

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[david-allison]

Did you manage to reproduce the error?

This seems to convert the crash into a bug

[Giyutomioka-SS]

I couldn’t reproduce the crash. Should I add a null check and logging to catch cases where the adapter or filter is unexpectedly null?

[david-allison]

We shouldn't rush to a solution

The first step is to understand how the crash occurred, and ideally being able to reproduce it. Once we know this, we'll ideally be able to fix the cause rather than ignore user input

Did you check ACRA for a logcat?

[mikehardy]

getting closer to something that might move this one forward, but needs to go to our ACRA server for it to be seen

[mikehardy]

That's what I had in mind - doesn't fix the underlying issue but will hopefully get us closer. Thank you

[mikehardy]

Going to put this one in as well for 2.19.3, it stops the crash but adds logging and doesn't hide it in acra