Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move bash executable comment to top of script to allow for fish shell execution #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davetorbeck
Copy link

@davetorbeck davetorbeck commented Jun 22, 2018

# Copyright: (c) 2018, Aniket Panjwani <[email protected]>
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
#!/bin/bash

The first two comment lines for the license in the chomper/bin/chomper bash script will cause an error when executed in fish shell.

$ /home/david/chomper/bin/chomper nosocial 3
Failed to execute process '/home/david/chomper/bin/chomper'. Reason:
exec: Exec format error
The file '/home/david/chomper/bin/chomper' is marked as an executable but could not be run by the operating system.

Moving #!bin/bash/ to the top of the script allows execution within fish shell.

@CLAassistant
Copy link

CLAassistant commented Jun 22, 2018

CLA assistant check
All committers have signed the CLA.

@davetorbeck davetorbeck changed the title Move bash comment lines below for fish execution Move bash executable comment to top of script to allow for fish shell execution Jun 22, 2018
Copy link

@pkill37 pkill37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Please merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants