Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Реализовать страницу Error (для отображения ошибок) #31

Closed
2 tasks
azinit opened this issue Oct 24, 2020 · 4 comments · Fixed by #120
Closed
2 tasks

Реализовать страницу Error (для отображения ошибок) #31

azinit opened this issue Oct 24, 2020 · 4 comments · Fixed by #120
Assignees
@niyazm524
Labels
CRITICAL Highest priority and severity enhancement New feature or request IMPORTANT Important and significant
Milestone
Спринт 2020_6

Comments

@azinit
Copy link
Member

azinit commented Oct 24, 2020 •
edited
Loading

  • Возможно, стоит предварительно разобраться с Разобраться с errors-handling #4
  • "Каждая ошибка которая может возникнуть в приложении должна быть обработана"
@azinit azinit added the enhancement New feature or request label Oct 24, 2020
@azinit azinit added this to the Спринт 2020_2 milestone Oct 24, 2020
@azinit azinit pinned this issue Nov 9, 2020
@azinit
Copy link
Member Author

azinit commented Nov 10, 2020

404 должно быть (для users / repo - и в целом для невалидных ссылок)

image

@azinit azinit added the IMPORTANT Important and significant label Nov 16, 2020
@azinit
Copy link
Member Author

azinit commented Nov 17, 2020

@niyazm524

Впринципе некритично, но если бы ты заюзал ту home-hero фичу, которую Аделия делала и адаптировал под свои нужды (а там UI и логика оч похожа у того что тебе надо и тут) - былоб прям круто
(и фичи реюзабельные были бы, как я прям хотел по #82 )

image

image

@azinit
Copy link
Member Author

azinit commented Nov 17, 2020

Но возможно тогда фичу лучше переименовать будет (и на home-page адаптировать)

Отпиши потом - получилось ли, на крайняк - потом отдельно сам этим займусь по #82

@azinit
Copy link
Member Author

azinit commented Nov 18, 2020 •
edited
Loading

Не успеваем по срокам 🤷‍♂️, переносим в v.0.1.X

@azinit azinit added the CRITICAL Highest priority and severity label Nov 19, 2020
@niyazm524 niyazm524 mentioned this issue Nov 25, 2020
Merged
@azinit azinit unpinned this issue Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niyazm524 niyazm524

Labels
CRITICAL Highest priority and severity enhancement New feature or request IMPORTANT Important and significant
Projects
None yet
Milestone
Спринт 2020_6
Development

Successfully merging a pull request may close this issue.

Обработка ошибок GraphQL ani-team/github-client
2 participants
@niyazm524 @azinit