Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilizing nullable reference types #789

Merged
merged 4 commits into from
May 27, 2020

Conversation

tmilnthorp
Copy link
Collaborator

Per #688

@tmilnthorp
Copy link
Collaborator Author

@angularsen I am not sure how to fix this build

@angularsen
Copy link
Owner

Well, the error says

CSC : error CS8630: Invalid 'nullable' value: 'Enable' for C# 7.3. Please use language version 'preview' or greater.

I'll try pushing a language version fix and see if it helps.

@angularsen
Copy link
Owner

It builds locally here, so must be environment specific.

@codecov-commenter
Copy link

Codecov Report

Merging #789 into master will decrease coverage by 0.01%.
The diff coverage is 56.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #789      +/-   ##
==========================================
- Coverage   63.90%   63.89%   -0.02%     
==========================================
  Files         280      280              
  Lines       41691    41684       -7     
==========================================
- Hits        26641    26632       -9     
- Misses      15050    15052       +2     
Impacted Files Coverage Δ
UnitsNet/CustomCode/Quantities/Length.extra.cs 86.51% <ø> (ø)
UnitsNet/CustomCode/Quantities/Mass.extra.cs 93.87% <ø> (ø)
UnitsNet/GeneratedCode/Quantity.g.cs 81.45% <ø> (ø)
...sNet/InternalHelpers/ReflectionBridgeExtensions.cs 46.15% <0.00%> (ø)
UnitsNet/QuantityFormatter.cs 96.55% <ø> (ø)
UnitsNet/UnitFormatter.cs 100.00% <ø> (ø)
...nitsNet/GeneratedCode/Quantities/Acceleration.g.cs 59.77% <50.00%> (ø)
...et/GeneratedCode/Quantities/AmountOfSubstance.g.cs 61.29% <50.00%> (ø)
...tsNet/GeneratedCode/Quantities/AmplitudeRatio.g.cs 50.84% <50.00%> (ø)
UnitsNet/GeneratedCode/Quantities/Angle.g.cs 60.27% <50.00%> (ø)
... and 104 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23467bc...1f4ef9a. Read the comment docs.

@angularsen
Copy link
Owner

Weird, I just upgraded to VS2019 image and it.. worked. I tried earlier and it.. well, didn't work :-) Maybe the appveyor images have been improved since then.

@tmilnthorp
Copy link
Collaborator Author

Glad it works! Everything ok to merge? I just did the main UnitsNet project for now. We can work on projects in parts.

I'm also guessing that component runtime doesn't support this.

@angularsen angularsen merged commit 9906b96 into angularsen:master May 27, 2020
@angularsen
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants