-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilizing nullable reference types #789
Conversation
@angularsen I am not sure how to fix this build |
Well, the error says
I'll try pushing a language version fix and see if it helps. |
It builds locally here, so must be environment specific. |
Codecov Report
@@ Coverage Diff @@
## master #789 +/- ##
==========================================
- Coverage 63.90% 63.89% -0.02%
==========================================
Files 280 280
Lines 41691 41684 -7
==========================================
- Hits 26641 26632 -9
- Misses 15050 15052 +2
Continue to review full report at Codecov.
|
Weird, I just upgraded to VS2019 image and it.. worked. I tried earlier and it.. well, didn't work :-) Maybe the appveyor images have been improved since then. |
Glad it works! Everything ok to merge? I just did the main UnitsNet project for now. We can work on projects in parts. I'm also guessing that component runtime doesn't support this. |
Per #688