Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show example of en vs en-US liters preference (l/L) #1209

Closed
wants to merge 1 commit into from

Conversation

tmilnthorp
Copy link
Collaborator

Example for addressing #1115

@angularsen
Copy link
Owner

angularsen commented Mar 12, 2023

I think it is a neat idea, but I am not convinced there is a strong enough correlation between the culture you are running and the user's preference for L vs l.

As a counter-example, in Norwegian we use both "l" and "L".
I had no specific intuition on when to use what, but apparently our national language council recommends "L" for technical domains.

l | liter
L | liter (i teknisk språk)

https://www.sprakradet.no/sprakhjelp/Skriveregler/Forkortinger/

So if we wanted "L" for Norwegian, we would have to "translate" all liter units to Norwegian. And insert N other countries with similar behavior. I don't think it scales very well.

SI standard accepts both, so there is bound to be a mix internationally.
I'm thinking we should maybe instead just make it configurable and maybe that configuration's default could be based on the culture?

Not exactly sure how to make it configurable, beyond calling some static method on startup that re-configures unit abbreviations for liter units. Maybe we can have something enumerate all units with "liter" in the unit name and replace "L" with "l" and vice versa?

@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 18, 2023
@angularsen
Copy link
Owner

angularsen commented Jul 8, 2024

Related fix #1404

Closing this for now, I don't expect a big demand for this.

@angularsen angularsen closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants