Skip to content
This repository has been archived by the owner on Feb 9, 2020. It is now read-only.

angular 1.6.3 breaks batarang #307

Closed
ygilliot opened this issue Mar 19, 2017 · 8 comments
Closed

angular 1.6.3 breaks batarang #307

ygilliot opened this issue Mar 19, 2017 · 8 comments

Comments

@ygilliot
Copy link

Enabling batarang while working with angular 1.6.3 totally breaks the application to watch.
I don't know why, it's working fine in 1.6.2. I use angular via cdn but i don't think the problem comes from that.

Could someone investigate, if project is still alive? thanks.

Here is what chrome's console outputs:

Uncaught TypeError: ac(...).info is not a function
at Ce (angular.js:2793)
at angular.js:33194
at angular.js:6
Ce @ angular.js:2793
(anonymous) @ angular.js:33194
(anonymous) @ angular.js:6

angular-sanitize.js:555Uncaught TypeError: f.module(...).provider(...).info is not a function
at angular-sanitize.js:555
at angular-sanitize.js:6
(anonymous) @ angular-sanitize.js:555
(anonymous) @ angular-sanitize.js:6

angular-messages.js:267Uncaught TypeError: l.module(...).info is not a function
at angular-messages.js:267
at angular-messages.js:6
(anonymous) @ angular-messages.js:267
(anonymous) @ angular-messages.js:6

angular-cookies.js:24Uncaught TypeError: c.module(...).info is not a function
at angular-cookies.js:24
at angular-cookies.js:6
(anonymous) @ angular-cookies.js:24
(anonymous) @ angular-cookies.js:6

angular.js:38Uncaught Error: [$injector:modulerr] http://errors.angularjs.org/1.6.3/$injector/modulerr?p0=ng&p1=Error%3A%20%5…udflare.com%2Fajax%2Flibs%2Fangular.js%2F1.6.3%2Fangular.min.js%3A22%3A277)
at angular.js:38
at angular.js:4920
at p (angular.js:402)
at g (angular.js:4880)
at eb (angular.js:4802)
at c (angular.js:1909)
at Object.Pc.ea.resumeBootstrap (angular.js:1938)
at maybeBootstrap (hint.js:569)

@ocombe
Copy link

ocombe commented Mar 20, 2017

As far as I know this is no longer maintained, it was @btford's project and he left google a year ago...

@gkalpak
Copy link
Member

gkalpak commented Mar 20, 2017

Sorry, I haven't given batarang much love lately 😁
We should definitely fix this issue, though. I'll look into it this week.

@ygilliot
Copy link
Author

Great! as far as I know, there's no better chrome extension for Angular 1 apps. It would be awful if support stops at 1.6

@MustafaSange
Copy link

Same here downloaded Batarang and it's not working. Hope it will be fixed soon.

gkalpak referenced this issue in angular/angular.js Mar 23, 2017
You can now check what version of AngularJS a core module is designed for:

```
var angularVersion = $injector.modules['myModule'].info().angularVersion;
```
gkalpak added a commit to gkalpak/batarang that referenced this issue Mar 23, 2017
gkalpak added a commit to gkalpak/batarang that referenced this issue Mar 23, 2017
gkalpak added a commit to gkalpak/batarang that referenced this issue Mar 24, 2017
@gary-b
Copy link
Contributor

gary-b commented Mar 24, 2017

Last I heard, there was no one to handle releases to the chrome web store. Do we have someone now, or is it just for major fixes?

@gkalpak
Copy link
Member

gkalpak commented Mar 25, 2017

We have me 😃
I would like to merge angular/angular-hint#122 and angular/angular-hint#123 before cutting a new release. I hope to get it out early next week.

@gkalpak
Copy link
Member

gkalpak commented Mar 30, 2017

Update
angular/angular-hint#123 is in.
I have a better alternative to #122 (correctly detecting _and_tracking watched one-time expressions): angular/angular-hint#124

Once #124 is in (hopefully this week), we can cut the release.

@gkalpak
Copy link
Member

gkalpak commented Mar 31, 2017

v0.10.8 is out, but it's broken. Tracking in #310.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants