diff --git a/Geometry/TrackerCommonData/data/PhaseI/trackerStructureTopology.xml b/Geometry/TrackerCommonData/data/PhaseI/trackerStructureTopology.xml index 04a031a7ef02e..2045be4e3b85a 100644 --- a/Geometry/TrackerCommonData/data/PhaseI/trackerStructureTopology.xml +++ b/Geometry/TrackerCommonData/data/PhaseI/trackerStructureTopology.xml @@ -1,5 +1,5 @@ - + @@ -271,7 +271,7 @@ - + @@ -288,7 +288,7 @@ - + @@ -301,123 +301,123 @@ - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + diff --git a/Geometry/TrackerGeometryBuilder/src/TrackerGeomBuilderFromGeometricDet.cc b/Geometry/TrackerGeometryBuilder/src/TrackerGeomBuilderFromGeometricDet.cc index 55dd2b5f9458e..f995eeb14ad41 100644 --- a/Geometry/TrackerGeometryBuilder/src/TrackerGeomBuilderFromGeometricDet.cc +++ b/Geometry/TrackerGeometryBuilder/src/TrackerGeomBuilderFromGeometricDet.cc @@ -165,19 +165,18 @@ void TrackerGeomBuilderFromGeometricDet::buildPixel( tracker->setOffsetDU(GeomDetEnumerators::subDetGeom[det]); - for (auto i : gdv) { + for (auto const& i : gdv) { std::string const& detName = i->name(); if (thePixelDetTypeMap.find(detName) == thePixelDetTypeMap.end()) { std::unique_ptr bounds(i->bounds()); - - PixelTopology* t = PixelTopologyBuilder().build(&*bounds, + PixelTopology* t = PixelTopologyBuilder().build(bounds.get(), upgradeGeometry, - i->pixROCRows(), - i->pixROCCols(), + (int)i->pixROCRows(), + (int)i->pixROCCols(), BIG_PIX_PER_ROC_X, BIG_PIX_PER_ROC_Y, - i->pixROCx(), - i->pixROCy()); + (int)i->pixROCx(), + (int)i->pixROCy()); thePixelDetTypeMap[detName] = new PixelGeomDetType(t, detName, det); tracker->addType(thePixelDetTypeMap[detName]); @@ -203,11 +202,11 @@ void TrackerGeomBuilderFromGeometricDet::buildSilicon(std::vectorsetOffsetDU(GeomDetEnumerators::subDetGeom[det]); - for (auto i : gdv) { + for (auto const& i : gdv) { std::string const& detName = i->name(); if (theStripDetTypeMap.find(detName) == theStripDetTypeMap.end()) { std::unique_ptr bounds(i->bounds()); - StripTopology* t = StripTopologyBuilder().build(&*bounds, i->siliconAPVNum(), part); + StripTopology* t = StripTopologyBuilder().build(bounds.get(), i->siliconAPVNum(), part); theStripDetTypeMap[detName] = new StripGeomDetType(t, detName, det, i->stereo()); tracker->addType(theStripDetTypeMap[detName]); } diff --git a/Geometry/TrackerNumberingBuilder/src/GeometricDet.cc b/Geometry/TrackerNumberingBuilder/src/GeometricDet.cc index 5146d235eae72..aec43b9bf5b89 100644 --- a/Geometry/TrackerNumberingBuilder/src/GeometricDet.cc +++ b/Geometry/TrackerNumberingBuilder/src/GeometricDet.cc @@ -105,8 +105,6 @@ GeometricDet::GeometricDet(cms::DDFilteredView* fv, GeometricEnumType type) rot_(fv->rotation()), shape_(fv->shape()), params_(computeLegacyShapeParameters(shape_, fv->solid())), - radLength_(fv->get("TrackerRadLength")), - xi_(fv->get("TrackerXi")), pixROCRows_(fv->get("PixelROCRows")), pixROCCols_(fv->get("PixelROCCols")), pixROCx_(fv->get("PixelROC_X")), @@ -115,7 +113,11 @@ GeometricDet::GeometricDet(cms::DDFilteredView* fv, GeometricEnumType type) isLowerSensor_(fv->get("TrackerLowerDetectors") == strue), isUpperSensor_(fv->get("TrackerUpperDetectors") == strue), siliconAPVNum_(fv->get("SiliconAPVNumber")), - isFromDD4hep_(true) {} + isFromDD4hep_(true) { + fv->findSpecPar("TrackerRadLength", "TrackerXi"); + radLength_ = fv->getNextValue("TrackerRadLength"); + xi_ = fv->getNextValue("TrackerXi"); +} /* Constructor from persistent version (DB).