Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoW Cw721 #697
base: main
Are you sure you want to change the base?
PoW Cw721 #697
Changes from all commits
e11d97b
c8953e6
6e9ea18
dde31a6
feb0aa6
59f3110
b3682d1
c053ef6
bee0921
9771873
9437432
309cf93
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Handle potential panics when converting hash bytes to
u128
.The use of
unwrap()
inhash[0..16].try_into().unwrap()
can cause a panic if the slice does not have the correct length. Consider handling the potential error using?
to propagate it properly.Apply this diff to handle the error:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using floating-point arithmetic in smart contracts.
The difficulty adjustment uses floating-point arithmetic, which can lead to non-deterministic behavior and precision issues in smart contracts. It's recommended to use integer arithmetic to ensure deterministic and precise calculations.
Apply this diff to adjust the difficulty calculation:
This change replaces the floating-point multiplication with integer arithmetic, ensuring consistent behavior across different platforms.
📝 Committable suggestion