Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Restore Credential Support for Shrine app #104

Draft
wants to merge 1 commit into
base: shrine-compose
Choose a base branch
from

Conversation

neelanshsahai
Copy link

Change-Id: I476116b1f3400c452783d2f172bd7adbca5fcadb

Change-Id: I476116b1f3400c452783d2f172bd7adbca5fcadb
@@ -36,12 +36,12 @@ keystoreProperties.load(FileInputStream(keystorePropertiesFile))

android {
namespace = "com.example.android.authentication.shrine"
compileSdk = 34
compileSdk = 35
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the app tested on both Android 14 & lower and 15?

) {
val passkeysEligibility = PasskeysEligibility.isPasskeySupported(context)
if (passkeysEligibility.isEligible) {
val restoreCredentialRequest = CreateRestoreCredentialRequest(requestResult.toString())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be null?

Copy link

@danjkim danjkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can the backup integration also be included to the test app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants