-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Restore Credential Support for Shrine app #104
base: shrine-compose
Are you sure you want to change the base?
Conversation
Change-Id: I476116b1f3400c452783d2f172bd7adbca5fcadb
@@ -36,12 +36,12 @@ keystoreProperties.load(FileInputStream(keystorePropertiesFile)) | |||
|
|||
android { | |||
namespace = "com.example.android.authentication.shrine" | |||
compileSdk = 34 | |||
compileSdk = 35 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the app tested on both Android 14 & lower and 15?
) { | ||
val passkeysEligibility = PasskeysEligibility.isPasskeySupported(context) | ||
if (passkeysEligibility.isEligible) { | ||
val restoreCredentialRequest = CreateRestoreCredentialRequest(requestResult.toString()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be null?
Shrine/app/src/main/java/com/example/android/authentication/shrine/CredentialManagerUtils.kt
Show resolved
Hide resolved
Shrine/app/src/main/java/com/example/android/authentication/shrine/CredentialManagerUtils.kt
Show resolved
Hide resolved
Shrine/app/src/main/java/com/example/android/authentication/shrine/ui/RegisterScreen.kt
Show resolved
Hide resolved
Shrine/app/src/main/java/com/example/android/authentication/shrine/CredentialManagerUtils.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can the backup integration also be included to the test app?
Change-Id: I476116b1f3400c452783d2f172bd7adbca5fcadb