-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JetChat] Add glance widget for JetChat App #1424 #1425
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatDrawer.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR!
Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatDrawer.kt
Outdated
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatDrawer.kt
Outdated
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/data/FakeData.kt
Outdated
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/widget/composables/MessagesWidget.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I've added my feedback, and +1 all of @mlykotom's points.
Are you expecting to add live data to the widget too, or only stick with static data?
Jetchat/app/src/main/java/com/example/compose/jetchat/widget/composables/MessagesWidget.kt
Outdated
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/widget/composables/MessagesWidget.kt
Outdated
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/widget/composables/MessagesWidget.kt
Outdated
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/widget/WidgetReceiver.kt
Show resolved
Hide resolved
Thanks for the review @secondsun and @mlykotom will work on these over the weekend and will re-request a review. |
…troduced themes and text styles for glance widget.
@secondsun @mlykotom Can you guys take a look at the PR now ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found one thing with linting. Line is too long.
Added an Unreads widget for the JetChat app using Glance. Also has a option to add widget to home screen on the app.
Glance.Widget.Recording.webm
Fixes #1424