-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M3 conversion #367
M3 conversion #367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment otherwise lgtm but would like @JolandaVerhoef to review as well
BasicLayoutsCodelab/app/src/main/java/com/codelab/basiclayouts/MainActivity.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good given you're trying to copy the Figma design. However, some of the changes mean that the codelab explanation will become more complex. For example, you're often overriding the default color or style of elements, where we weren't doing that before. That might make it hard to explain these additions in the codelab text.
You might want to check with our designer if they had a solid reason to override these values, or if this was an unintended side-effect of the migration of the design.
Also, adding the spacers instead of using the paddingFromBaseline might break some of our explanations. For example, at the top of https://developer.android.com/codelabs/jetpack-compose-layouts#8 you can see that we previously used a baseline-based spacing. In the new Figma file, it looks like this has been replaced with spacers between elements. That will make it much harder to update the codelab text, so you might want to consider double checking this with the designer.
Opening on behalf of @MagicalMeghan