Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M3 conversion #367

Merged
merged 11 commits into from
Aug 16, 2023
Merged

M3 conversion #367

merged 11 commits into from
Aug 16, 2023

Conversation

arriolac
Copy link
Contributor

@arriolac arriolac commented Jul 10, 2023

Opening on behalf of @MagicalMeghan

Copy link
Contributor

@florina-muntenescu florina-muntenescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment otherwise lgtm but would like @JolandaVerhoef to review as well

Copy link
Contributor

@JolandaVerhoef JolandaVerhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good given you're trying to copy the Figma design. However, some of the changes mean that the codelab explanation will become more complex. For example, you're often overriding the default color or style of elements, where we weren't doing that before. That might make it hard to explain these additions in the codelab text.

You might want to check with our designer if they had a solid reason to override these values, or if this was an unintended side-effect of the migration of the design.

Also, adding the spacers instead of using the paddingFromBaseline might break some of our explanations. For example, at the top of https://developer.android.com/codelabs/jetpack-compose-layouts#8 you can see that we previously used a baseline-based spacing. In the new Figma file, it looks like this has been replaced with spacers between elements. That will make it much harder to update the codelab text, so you might want to consider double checking this with the designer.

@MagicalMeghan MagicalMeghan merged commit 9e94a9f into end Aug 16, 2023
@MagicalMeghan MagicalMeghan deleted the m3-conversion branch August 16, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants