Remove Orchestrator's single method fast path #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettchabot
reviewed
Jan 31, 2024
| getOutputStream(), | ||
| AndroidTestOrchestrator.this)); | ||
| } | ||
| Log.i(TAG, "Starting test collection"); |
There was a problem hiding this comment.
this change looks reasonable but I'm concerned over the performance impact on the 'normal' case of just running a single, non-parameterized method. Test discovery will require launching and killing the target app process, so for large apps its not cheap.
Notably, some environments use a host-side based test collection mechanism. So with this change those environments might run test discovery twice.
There was a problem hiding this comment.
That's very fair. I suppose there are a few alternatives:
- Just accept and ideally document this wart for parameterized tests.
- Some kind of speculative single-method execution path that would keep the current behaviour in the common case where it really is just 1 test, or report a list of tests back to orchestrator in the parameterized case.
But you may well have some better suggestions, I'm not that familar with the internals of androidx.test. 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #2132.
Orchestrator has a fast path that skips test discovery if the test target is a single method. This doesn't work for parameterized tests, since even a single method target may expand to any number of parameterized test instances.
Proposed Changes
Remove the fast path and always run test discovery, because I don't think it's possible to know ahead of time whether a test target expands to exactly 1 test.
Tested locally by running:
and running one of the parameterised tests in our repo against the
1.5.0-alpha03orchestrator artifacts in~/.m2(mavenLocal()in Gradle build scripts).