Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support std::time::Duration #2

Closed
jonhoo opened this issue Nov 15, 2017 · 10 comments
Closed

Support std::time::Duration #2

jonhoo opened this issue Nov 15, 2017 · 10 comments

Comments

@jonhoo
Copy link

jonhoo commented Nov 15, 2017

ferris currently operates on time::Duration from the (deprecated) time crate. It would be great if it could instead use the standard Duration struct from std::time.

@andrewjstone
Copy link
Owner

whoops I accidentally clicked the close button. I agree this would be good. I'm working with a few people on my team learning Rust right now and I might point one of them at this as it's an easy issue. I already have 1 person looking at issue #1, but it's not his top priority. This itself should be a very simple change, and I can probably just do it. It's just nice to see commits from others :)

@jonhoo
Copy link
Author

jonhoo commented Nov 15, 2017

I'd also be happy to give some guidance if you're swamped.

@andrewjstone
Copy link
Owner

Thanks Jon. If it's of an immediate need and you want to go ahead and implement that would be nice. If it can wait a few days I or someone on my team will go ahead and do it. It should be very easy. Today is my first day back from vacation, so a bit swamped playing catchup.

@jonhoo
Copy link
Author

jonhoo commented Nov 16, 2017

No rush at all. I just added a dependency on time and used time::Duration::from in the meantime. I'd just like to remove that legacy dependency eventually.

@andrewjstone
Copy link
Owner

Got it. I'll keep it high on my list. I'm very happy to hear that you are using ferris btw. I'm a big fan of hdrsample, although I haven't gotten a chance to really use it in depth. Been kind of in a different world the last few months, with rust stuff lagging a bit. That's about to change though. May I ask what you are using ferris for?

@jonhoo
Copy link
Author

jonhoo commented Nov 16, 2017

Glad to hear you like hdrsample! :)

I'm using ferris to track batching timeouts across a number of input channels in a data-flow database research prototype I'm building over at https://github.com/mit-pdos/distributary. It's being used pretty deep in the internals, but if you're curious, the timers appear near https://github.com/mit-pdos/distributary/blob/a8e8a56a644578b6c329f9a6ec9853ba4836710b/src/worker/worker.rs#L197.

@andrewjstone
Copy link
Owner

That project looks awesome. I'll have to give the Soup paper a read.

@jonhoo
Copy link
Author

jonhoo commented Nov 16, 2017

There unfortunately isn't a full paper out (yet), but some preliminary work is described here: https://jon.thesquareplanet.com/papers/sosp17src-xylem.pdf

@andrewjstone
Copy link
Owner

I realized that when I clicked on the slide link that I thought was going to be a paper. Thanks for the link.

@andrewjstone
Copy link
Owner

closed by #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants