Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete iroh discovery when Iroh supports it #737

Open
andrewdavidmackenzie opened this issue Dec 12, 2024 · 1 comment
Open

Complete iroh discovery when Iroh supports it #737

andrewdavidmackenzie opened this issue Dec 12, 2024 · 1 comment
Labels
blocked can't work on it for now bug Something isn't working

Comments

@andrewdavidmackenzie
Copy link
Owner

See code in find_piglets():

map.insert(
            trunc, // TODO substitute for real serial_number when Iroh discovery supports it
            DiscoveredDevice {
                discovery_method: IrohLocalSwarm,
                hardware_details: hw::driver::get().description().unwrap().details, // TODO show the real hardware description when Iroh discovery supports it
                ssid_spec: None,
                hardware_connection: HardwareConnection::Iroh(
                    remote.node_id,
                    remote.relay_url.map(|ri| ri.relay_url),
                ),
            },
        );

And get the additional properties via Iroh.

@andrewdavidmackenzie andrewdavidmackenzie added the bug Something isn't working label Dec 12, 2024
@andrewdavidmackenzie andrewdavidmackenzie added this to the 0.7.0 Release milestone Dec 12, 2024
@andrewdavidmackenzie
Copy link
Owner Author

Submitted to Irho here: n0-computer/iroh#3037

@andrewdavidmackenzie andrewdavidmackenzie added the blocked can't work on it for now label Dec 17, 2024
@andrewdavidmackenzie andrewdavidmackenzie removed this from the 0.7.0 Release milestone Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked can't work on it for now bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant