Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a text box with number format to enter quantity in config flow #77

Closed
3 tasks done
uvjim opened this issue Dec 17, 2023 · 2 comments · Fixed by #469
Closed
3 tasks done

Use a text box with number format to enter quantity in config flow #77

uvjim opened this issue Dec 17, 2023 · 2 comments · Fixed by #469
Assignees
Labels
enhancement New feature or request

Comments

@uvjim
Copy link
Contributor

uvjim commented Dec 17, 2023

Checklist

  • I have filled out the template to the best of my ability.
  • This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
  • This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.

The config flow contains a label to "optionally" enter the number of batteries a device takes. It's possible to enter this in a format that doesn't like up with that used by the sensor when completed via the library. This creates an inconsistent view in the UI.

Describe the solution you'd like

A textbox in the config flow to allow entry of the quantity (defaulting to 1). This would allow processing and for atting the same way as those populated by the library.

Describe alternatives you've considered

Defining the format of entry in the label stating that it is optional.

Additional context

The entry screen in the config flow.

image

Badly formatted battery type with quantity.
image

Correctly formatted battery type from library.
image

@andrew-codechimp
Copy link
Owner

I like the quantity input idea but as I'm in the code today I've quickly adding a hint until I can work on it more.

@andrew-codechimp andrew-codechimp added the enhancement New feature or request label Dec 17, 2023
@andrew-codechimp andrew-codechimp self-assigned this Jan 9, 2024
@andrew-codechimp
Copy link
Owner

I have a migration plan to fully achieve this which I'll be rolling out in the next few weeks, see #421

@andrew-codechimp andrew-codechimp linked a pull request Jan 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants