Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device: SAF Tehnika - null #2462

Closed
derobert opened this issue Dec 1, 2024 · 5 comments
Closed

Device: SAF Tehnika - null #2462

derobert opened this issue Dec 1, 2024 · 5 comments
Labels
new-device A new device automated PR

Comments

@derobert
Copy link

derobert commented Dec 1, 2024

Manufacturer

SAF Tehnika

Model

null

Model ID

null

HW Version

null

Battery Type

AA

Battery Quantity

2

@derobert derobert added the new-device A new device automated PR label Dec 1, 2024
@github-actions github-actions bot changed the title [Device]: Aranet 4 Device: SAF Tehnika - null Dec 1, 2024
Copy link
Contributor

github-actions bot commented Dec 1, 2024

Thanks for the contribution. We're auto-closing this issue. If it's a new device, a pull request will be created that will be reviewed and merged.

@derobert
Copy link
Author

derobert commented Dec 1, 2024

From the JSON:

    "device": {
      "manufacturer": "SAF Tehnika",
      "model": null,
      "model_id": null,
      "hw_version": null
    }

I'm not sure how to tell an Aranet 4 apart from other Aranet devices.

@andrew-codechimp
Copy link
Owner

The null's don't look right.
If you go into Configure on this battery note what does it say at the top for model etc?

@derobert
Copy link
Author

@andrew-codechimp
The GUI just omits the fields;
Screenshot_20241209-234531

And editing the battery notes shows blanks:
Screenshot_20241209-234742

Those nulls are what you get from downloading the diagnostics JSON.

@andrew-codechimp
Copy link
Owner

Thanks for the clarification, the null within diagnostics indicates that the Aranet integration does not expose a model.
The library needs a model to match against, so in this case you will have to add them manually as you have done so.
There are not many integrations that skip the model but I've seen a few unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-device A new device automated PR
Projects
None yet
Development

No branches or pull requests

2 participants