Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fast immergancy fix : use GetExportedTypes() #24

Open
kianzarrin opened this issue Feb 17, 2021 · 1 comment
Open

fast immergancy fix : use GetExportedTypes() #24

kianzarrin opened this issue Feb 17, 2021 · 1 comment

Comments

@kianzarrin
Copy link

Use GetExportedTypes() instead of GetTypes()

Reasons:

  • The game does useGetExportedTypes() every time it loads an assembly so using GetExportedTypes() is harmless
  • calling GetTypes() makes NExt2 incompatible with mods that have direct references to other mods (not only harmony)
  • avoiding direct references in private types is hard because sometimes the compiler creates hidden private types.
@kianzarrin kianzarrin changed the title fast immergancy fix fast immergancy fix : use GetExportedTypes() Feb 17, 2021
@kianzarrin
Copy link
Author

@andreharv I will now fork NExt2 and do this. should I create a PR? do you need the dll as well?

@kianzarrin kianzarrin mentioned this issue Feb 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replaced GetTypes with GetExportedTypes kianzarrin/NetworkExtensions
1 participant
@kianzarrin