-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roms filtered out that shouldn't be (keeps World, when Europe is prefered and exists) #48
Comments
Hm, that's weird. Unlicensed titles shouldn't be preferred over licensed ones. Let me take a look here and I'll get back to you. |
Ok, I think I understand why this happened. The sorting logic thinks those unlicensed ROMs are better because they have more of the regions you selected.
Could you try adding the following to your command and see if it helps?
|
Thanks a lot for your fast reply. Using However, I have to say the way the generator currently works is highly counter-intuitive. When specifying Thus, I would expect the following prioritization order: Germany, Europe, USA, World. "Europe" is 100% Europe, "USA" is 100% USA. "World" is only 33% Europe. Why not go for "Europe" over "World" when it is explicitly stated in 2nd place? I also came across this thread that seems to be about the same issue: #43 Though I haven't looked into DATROMTool you mentioned yet. Maybe that's a solution. |
I get some roms filtered out although they shouldn't be. I'm working on a NES set with a No-Intro p/c dat.
My command:
python generate.py -r GER,EUR,USA -l de,en --exclude "Virtual Console,GameCube" --no-all --all-regions-with-lang -d "C:\NoIntro1G1R\dats\Nintendo - Nintendo Entertainment System (Headered) (Parent-Clone) (20240317-074124).dat" -i "C:\NoIntro1G1R\Orig\NES" -o "C:\NoIntro1G1R\1G1R\NES"
This works for most of the roms. The ones form Germany are kept. If there isn't a rom from Germany, European ones are kept. Only after that USA and World. However, there are a few exceptions that make no sense to me. These are:
Castlevania (World) (Konami Collector's Series) (Unl).zip
is kept overCastlevania (Europe).zip
Castlevania II - Simon's Quest (World) (Konami Collector's Series) (Unl).zip
is kept overCastlevania II - Simon's Quest (Europe).zip
Castlevania III - Dracula's Curse (World) (Konami Collector's Series) (Unl).zip
is kept overCastlevania III - Dracula's Curse (Europe).zip
Contra (World) (Konami Collector's Series) (Unl).zip
is kept overProbotector (Europe).zip
Super C (World) (Konami Collector's Series) (Unl).zip
is kept overProbotector II - Return of the Evil Forces (Europe).zip
Jungle Book, The (World) (Disney Classic Games).zip
is kept overJungle Book, The (Europe).zip
Super Mario Bros. (World).zip
is kept overSuper Mario Bros. (Europe).zip
Any idea why this is happening?
The text was updated successfully, but these errors were encountered: