Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win32 wheels #43

Open
adityagoel4512 opened this issue Jul 27, 2023 · 5 comments
Open

win32 wheels #43

adityagoel4512 opened this issue Jul 27, 2023 · 5 comments

Comments

@adityagoel4512
Copy link

adityagoel4512 commented Jul 27, 2023

Currently it looks like wheels are not built for win32 (skipped in CI). Was there a reason I should be aware of for this, and would it be possible to support this in a new release?

@andreasvc
Copy link
Owner

I don't run Windows, so it's not something I would work on. I recommend to use WSL.

@adityagoel4512
Copy link
Author

adityagoel4512 commented Jul 27, 2023

I don't run Windows, so it's not something I would work on. I recommend to use WSL.

I'm happy to provide a PR that adds win32 builds in the CI. In principle I think it's possible and should be a relatively small change, I had a go here.

win32 release builds are necessary in a downstream project CI that would like to depend on this library so it would be very useful in that context. Would you be happy to accept a PR for this?

@andreasvc
Copy link
Owner

Sure

@dmwyatt
Copy link

dmwyatt commented Feb 23, 2024

@adityagoel4512 Did you ever get around to creating a PR?

@sarnold
Copy link

sarnold commented Sep 8, 2024

@adityagoel451 can you try the wheels here and see if they work for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants