-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix behavior with empty matches #27
Comments
Okay, but I don't yet see anything pointing to this behavior change, or how using the patch you just merged exhibits the old behavior in ubuntu focal with python 3.9.6 but I get the new behavior in python 3.9.6 locally. WTH?? Anyway, I got bounced from the original "this should match perl's behavior" discussion from 2007: https://bugs.python.org/issue1647489 to a closed bug and then a closed PR with no apparent fix: to another (later) closed bug on Python 3.7, Python 3.6, Python 2.7: https://bugs.python.org/issue25054 and now too I'm tired to bisect and I think I'd rather push a few updates on another PR anyway. |
It's an obscure issue. If Python cannot make up its mind about it, maybe we should just remove the test and document that the behavior is inconsistent. |
I have this one: sarnold#9 and everything is "fine" except coverage.py chokes with a parse error on the first |
Oh, I also split out 2 problematic tests so they can be deselected/marked with pytest. Right now there are 2 places where the None vs '' test fails with the patch applied (which are accounted for in the workflows and tox.ini). |
Finally, this will fail hard in python 3.10: borgbackup/borg#5683 Fixing that ^^ and removing PY2 support should help getting the test coverage enabled. |
…istent across versions/platforms, maybe the test should be disabled altogether. #27
Python 3.7 fixed bugs related to empty matches: https://bugs.python.org/issue1647489
The text was updated successfully, but these errors were encountered: