Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more scrolling with iOS 15.1 #406

Open
tifroz opened this issue Oct 27, 2021 · 10 comments
Open

No more scrolling with iOS 15.1 #406

tifroz opened this issue Oct 27, 2021 · 10 comments

Comments

@tifroz
Copy link
Contributor

tifroz commented Oct 27, 2021

This can be reproduced with the demo app running iOS 15.1 (screen capture)

RPReplay_Final1635358896_480p.mov
@chinh-tran
Copy link


Apparently moving the navbar using the frame property no longer works with iOS 15.1 (https://developer.apple.com/forums/thread/691975).

An alternative is to use CGAffineTransform, which seems to fix the issue:

navigationBar.transform = CGAffineTransform(translationX: 0, y: navigationBar.transform.ty - delta)

@TheDreamsWind
Copy link

TheDreamsWind commented Oct 28, 2021

I'm experiencing similar problem under iOS 14.5, and as far as i'm concerned the linked discussion has nothing to do with the library, since it modifies the nav. ber on behalf of the view controller owning it.

@guicolares
Copy link

Thanks @chinh-tran , I had the same bug and resolved it with this fix. May I create a PR ?

my fix branch

@dongtg-1485
Copy link

dongtg-1485 commented Nov 2, 2021

@guicolares
Thanks for your pull request. But when you use CGAffineTransform to update NavigationBar, topViewController.view.frame was not updated when scroll slowly.
I think we need to find an other solution.

@closure11
Copy link

@andreamazz Do you have any ideas about this? Apparently the main feature of this library was broken.

@andreamazz
Copy link
Owner

@andreamazz Do you have any ideas about this? Apparently the main feature of this library was broken.

Nope, I need to find the time to test this. Did anyone test against 15.2 beta by any chance?

@dungInte
Copy link

I have the same problem too. if use the transform by chinhtran it helps scroll to the top but navigation will lag frame size and title too.

@anhnt2309
Copy link

Any update on this? This break my app on app store.

@andreamazz
Copy link
Owner

I've looked into this, honestly I don't know how to fix it, you can see during the scrolling that UIKit is fighting against both the frame change and the opacity change, I'm afraid that's not much we can do at this point. I was hoping for an issue with 15.1, but 15.2.1 behaves the same. Why did they start enforcing this with 15.1 is beyond my comprehension.

@Okizeme
Copy link

Okizeme commented Apr 12, 2022

I think that answer from Apple might interest you: https://developer.apple.com/forums/thread/691975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants